You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/01 21:23:52 UTC
[GitHub] [kafka] C0urante opened a new pull request #8973: KAFKA-10218: Stop reading config topic in every subsequent tick if catchup fails once
C0urante opened a new pull request #8973:
URL: https://github.com/apache/kafka/pull/8973
[Jira](https://issues.apache.org/jira/browse/KAFKA-10218)
We added a `canReadConfigs` field to the `DistributedHerder` a while back that gets set to `false` if the herder fails to catch up to the end of the config topic, but never gets set to `true` again if catchup succeeds at a later point.
This PR adds logic to reset it to `true` when it's safe to.
A single unit test is tweaked to ensure that the herder doesn't keep unnecessarily trying to catch up to the end of the config topic during every tick.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rhauch merged pull request #8973: KAFKA-10218: Stop reading config topic in every subsequent tick if catchup fails once
Posted by GitBox <gi...@apache.org>.
rhauch merged pull request #8973:
URL: https://github.com/apache/kafka/pull/8973
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] rhauch commented on pull request #8973: KAFKA-10218: Stop reading config topic in every subsequent tick if catchup fails once
Posted by GitBox <gi...@apache.org>.
rhauch commented on pull request #8973:
URL: https://github.com/apache/kafka/pull/8973#issuecomment-657659116
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #8973: KAFKA-10218: Stop reading config topic in every subsequent tick if catchup fails once
Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #8973:
URL: https://github.com/apache/kafka/pull/8973#issuecomment-656247489
@gharris1727 @chia7712 @ncliang would any of you be interested in reviewing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on pull request #8973: KAFKA-10218: Stop reading config topic in every subsequent tick if catchup fails once
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #8973:
URL: https://github.com/apache/kafka/pull/8973#issuecomment-654289206
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org