You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/16 18:14:19 UTC

[GitHub] [arrow] bkietz opened a new pull request #8681: [WIP] use 'double' for the crib instead of 'void'

bkietz opened a new pull request #8681:
URL: https://github.com/apache/arrow/pull/8681


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] bkietz commented on pull request #8681: [WIP] use 'double' for the crib instead of 'void'

Posted by GitBox <gi...@apache.org>.
bkietz commented on pull request #8681:
URL: https://github.com/apache/arrow/pull/8681#issuecomment-728235768


   @github-actions crossbow submit conda-win-vs2017-py37


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] bkietz commented on pull request #8681: ARROW-10622: [R] Nameof should not use "void" as the crib

Posted by GitBox <gi...@apache.org>.
bkietz commented on pull request #8681:
URL: https://github.com/apache/arrow/pull/8681#issuecomment-729067833


   @kszucs I don't *think* renaming the tasks will break anything; they don't seem to be referenced by name anywhere based
   `rg 'conda-(osx|win|linux)-\S+'`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] xhochy commented on pull request #8681: ARROW-10622: [R] Nameof should not use "void" as the crib

Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8681:
URL: https://github.com/apache/arrow/pull/8681#issuecomment-729176030


   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #8681: [WIP] use 'double' for the crib instead of 'void'

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8681:
URL: https://github.com/apache/arrow/pull/8681#issuecomment-728236716


   Revision: ea40ddddb46b231b0f250a38e28660c25463b997
   
   Submitted crossbow builds: [ursa-labs/crossbow @ actions-723](https://github.com/ursa-labs/crossbow/branches/all?query=actions-723)
   
   |Task|Status|
   |----|------|
   |conda-win-vs2017-py37|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-723-azure-conda-win-vs2017-py37)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-723-azure-conda-win-vs2017-py37)|


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on pull request #8681: ARROW-10622: [R] Nameof should not use "void" as the crib

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8681:
URL: https://github.com/apache/arrow/pull/8681#issuecomment-729093207


   @github-actions crossbow submit -g r


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #8681: ARROW-10622: [R] Nameof should not use "void" as the crib

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8681:
URL: https://github.com/apache/arrow/pull/8681#issuecomment-729094338


   Revision: 38ee7d8917998205a0ebf1e71e5f1788ad96fa4b
   
   Submitted crossbow builds: [ursa-labs/crossbow @ actions-724](https://github.com/ursa-labs/crossbow/branches/all?query=actions-724)
   
   |Task|Status|
   |----|------|
   |conda-linux-gcc-py36-cpu-r36|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-conda-linux-gcc-py36-cpu-r36)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-conda-linux-gcc-py36-cpu-r36)|
   |conda-linux-gcc-py37-cpu-r40|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-conda-linux-gcc-py37-cpu-r40)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-conda-linux-gcc-py37-cpu-r40)|
   |conda-osx-clang-py36-r36|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-conda-osx-clang-py36-r36)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-conda-osx-clang-py36-r36)|
   |conda-osx-clang-py37-r40|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-conda-osx-clang-py37-r40)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-conda-osx-clang-py37-r40)|
   |conda-win-vs2017-py36-r36|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-conda-win-vs2017-py36-r36)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-conda-win-vs2017-py36-r36)|
   |conda-win-vs2017-py37-r40|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-conda-win-vs2017-py37-r40)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-conda-win-vs2017-py37-r40)|
   |homebrew-r-autobrew|[![TravisCI](https://img.shields.io/travis/ursa-labs/crossbow/actions-724-travis-homebrew-r-autobrew.svg)](https://travis-ci.org/ursa-labs/crossbow/branches)|
   |test-r-linux-as-cran|[![Github Actions](https://github.com/ursa-labs/crossbow/workflows/Crossbow/badge.svg?branch=actions-724-github-test-r-linux-as-cran)](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-724-github-test-r-linux-as-cran)|
   |test-r-rhub-ubuntu-gcc-release|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-test-r-rhub-ubuntu-gcc-release)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-test-r-rhub-ubuntu-gcc-release)|
   |test-r-rocker-r-base-latest|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-test-r-rocker-r-base-latest)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-test-r-rocker-r-base-latest)|
   |test-r-rstudio-r-base-3.6-bionic|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-test-r-rstudio-r-base-3.6-bionic)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-test-r-rstudio-r-base-3.6-bionic)|
   |test-r-rstudio-r-base-3.6-centos6|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-test-r-rstudio-r-base-3.6-centos6)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-test-r-rstudio-r-base-3.6-centos6)|
   |test-r-rstudio-r-base-3.6-centos8|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-test-r-rstudio-r-base-3.6-centos8)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-test-r-rstudio-r-base-3.6-centos8)|
   |test-r-rstudio-r-base-3.6-opensuse15|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-test-r-rstudio-r-base-3.6-opensuse15)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-test-r-rstudio-r-base-3.6-opensuse15)|
   |test-r-rstudio-r-base-3.6-opensuse42|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-test-r-rstudio-r-base-3.6-opensuse42)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-test-r-rstudio-r-base-3.6-opensuse42)|
   |test-ubuntu-18.04-r-sanitizer|[![Azure](https://dev.azure.com/ursa-labs/crossbow/_apis/build/status/ursa-labs.crossbow?branchName=actions-724-azure-test-ubuntu-18.04-r-sanitizer)](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-724-azure-test-ubuntu-18.04-r-sanitizer)|


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] bkietz closed pull request #8681: ARROW-10622: [R] Nameof should not use "void" as the crib

Posted by GitBox <gi...@apache.org>.
bkietz closed pull request #8681:
URL: https://github.com/apache/arrow/pull/8681


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nealrichardson commented on pull request #8681: ARROW-10622: [R] Nameof should not use "void" as the crib

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #8681:
URL: https://github.com/apache/arrow/pull/8681#issuecomment-728658681


   We should add the 6 jobs with `r_config` [here](https://github.com/apache/arrow/commit/7e740b83eba915c8d4d6f728b159cb0928ff2c39#diff-58624af974aef2e2980f03f99d2386e78e3fcb1a53d6a4b06612ded49ea8d449R136) to the `r` crossbow group so that we are more likely to catch issues like this before merging. And it would also be helpful if those task names could say `r` in them--I'm so used to seeing `conda` build failures in the nightly report that there was no chance I was going to notice that they were failing because R.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #8681: ARROW-10622: [R] Nameof should not use "void" as the crib

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8681:
URL: https://github.com/apache/arrow/pull/8681#issuecomment-728320080


   https://issues.apache.org/jira/browse/ARROW-10622


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] kszucs commented on pull request #8681: ARROW-10622: [R] Nameof should not use "void" as the crib

Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8681:
URL: https://github.com/apache/arrow/pull/8681#issuecomment-729166903


   > @kszucs I don't _think_ renaming the tasks will break anything; they don't seem to be referenced by name anywhere based
   > `rg 'conda-(osx|win|linux)-\S+'`
   
   Correct, the group definitions use glob patterns.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org