You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/25 22:48:06 UTC
[GitHub] [fineract] nikpawar89 opened a new pull request #781: Refactoring guideline added to README.md
nikpawar89 opened a new pull request #781:
URL: https://github.com/apache/fineract/pull/781
This commit adds guideline for code refactoring in README.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] nikpawar89 commented on pull request #781: Refactoring guideline added to README.md
Posted by GitBox <gi...@apache.org>.
nikpawar89 commented on pull request #781:
URL: https://github.com/apache/fineract/pull/781#issuecomment-619566202
> @nikpawar I would have put this just 1 paragraph higher, to group all PR related infos together, before release. But let me merge this, because I want to add something else in that chapter, so I'll just move it in my next PR, hope OK for you.
I am fine @vorburger , as long as it coveys the message :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #781: Refactoring guideline added to README.md
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #781:
URL: https://github.com/apache/fineract/pull/781#issuecomment-619514831
@nikpawar I would have put this just 1 paragraph higher, to group all PR related infos together, before release. But let me merge this, because I want to add something else in that chapter, so I'll just move it in my next PR, hope OK for you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #781: Refactoring guideline added to README.md
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #781:
URL: https://github.com/apache/fineract/pull/781#issuecomment-619517580
#782
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org