[Impala-ASF-CR] IMPALA-8205: Support number of true and false statistics for boolean column

["Sahil Takiar (Code Review)" <ge...@cloudera.org>]

Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14666 )

Change subject: IMPALA-8205: Support number of true and false statistics for boolean column
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14666/6/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java:

http://gerrit.cloudera.org:8080/#/c/14666/6/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@293
PS6, Line 293: "COUNT(CASE WHEN " + colRefSql + " = TRUE THEN 1 ELSE NULL END)");
> Hi Sahil, I do conduct a test to compare their performance;
thanks for taking a look. in that case, lets just stick the the one you currently have since it looks similar to the null count



-- 
To view, visit http://gerrit.cloudera.org:8080/14666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I991bee8e7fdc644d908289f5fe2ee8032cc2c431
Gerrit-Change-Number: 14666
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <58...@qq.com>
Gerrit-Reviewer: Anonymous Coward <58...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2020 20:17:47 +0000
Gerrit-HasComments: Yes