You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2012/10/27 16:49:11 UTC
[jira] [Created] (BOOKKEEPER-445) LOG.trace calls in Bookie.java
Flavio Junqueira created BOOKKEEPER-445:
-------------------------------------------
Summary: LOG.trace calls in Bookie.java
Key: BOOKKEEPER-445
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
Project: Bookkeeper
Issue Type: Improvement
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira
I suggest we put them in an if block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-445) LOG.trace calls in Bookie.java
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485560#comment-13485560 ]
Rakesh R commented on BOOKKEEPER-445:
-------------------------------------
Thanks Flavio and patch looks nice.
Could you please apply the same to following trace logs in "LedgerCacheImpl.java", as related to LOG.trace calls imprv.
{code}
if (lep.isClean()) {
LOG.trace("Page is clean {}", lep);
continue;
}
{code}
> LOG.trace calls in Bookie.java
> ------------------------------
>
> Key: BOOKKEEPER-445
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-445) LOG.trace calls in Bookie.java
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira updated BOOKKEEPER-445:
----------------------------------------
Priority: Minor (was: Major)
> LOG.trace calls in Bookie.java
> ------------------------------
>
> Key: BOOKKEEPER-445
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-445) LOG.trace calls in Bookie.java
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485596#comment-13485596 ]
Flavio Junqueira commented on BOOKKEEPER-445:
---------------------------------------------
Thanks for having a look, Rakesh. That one in LedgerCacheImpl is not hit very often, but fine, let's change it too.
> LOG.trace calls in Bookie.java
> ------------------------------
>
> Key: BOOKKEEPER-445
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: BOOKKEEPER-445.patch, BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-445) LOG.trace calls in Bookie.java
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497262#comment-13497262 ]
Ivan Kelly commented on BOOKKEEPER-445:
---------------------------------------
I assume Logger#trace has "if (!isTraceEnabled()) { return; }" at the very beginning.
> LOG.trace calls in Bookie.java
> ------------------------------
>
> Key: BOOKKEEPER-445
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: BOOKKEEPER-445.patch, BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-445) LOG.trace calls in Bookie.java
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497307#comment-13497307 ]
Ivan Kelly commented on BOOKKEEPER-445:
---------------------------------------
http://www.slf4j.org/faq.html#logging_performance
> LOG.trace calls in Bookie.java
> ------------------------------
>
> Key: BOOKKEEPER-445
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: BOOKKEEPER-445.patch, BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-445) LOG.trace calls in Bookie.java
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497241#comment-13497241 ]
Ivan Kelly commented on BOOKKEEPER-445:
---------------------------------------
This change is unnecessary. The whole point of "{}" is that the string formatting is not done if the log category is not enabled.
> LOG.trace calls in Bookie.java
> ------------------------------
>
> Key: BOOKKEEPER-445
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: BOOKKEEPER-445.patch, BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-445) LOG.trace calls in Bookie.java
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira updated BOOKKEEPER-445:
----------------------------------------
Attachment: BOOKKEEPER-445.patch
This is a simple improvement.
> LOG.trace calls in Bookie.java
> ------------------------------
>
> Key: BOOKKEEPER-445
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Attachments: BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-445) LOG.trace calls in Bookie.java
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497280#comment-13497280 ]
Flavio Junqueira commented on BOOKKEEPER-445:
---------------------------------------------
I've never heard of this before, but I have seen LOG messages severely impacting performance because of strings generated unnecessarily and that one reason for adding the if blocks. How can we make sure that this is doing what it is supposed to do? I couldn't find anything in the documentation.
> LOG.trace calls in Bookie.java
> ------------------------------
>
> Key: BOOKKEEPER-445
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: BOOKKEEPER-445.patch, BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-445) LOG.trace calls in Bookie.java
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira updated BOOKKEEPER-445:
----------------------------------------
Attachment: BOOKKEEPER-445.patch
> LOG.trace calls in Bookie.java
> ------------------------------
>
> Key: BOOKKEEPER-445
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: BOOKKEEPER-445.patch, BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-445) LOG.trace calls in Bookie.java
Posted by "Rakesh R (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485674#comment-13485674 ]
Rakesh R commented on BOOKKEEPER-445:
-------------------------------------
Thanks Flavio.
+1 Latest patch looks good.
> LOG.trace calls in Bookie.java
> ------------------------------
>
> Key: BOOKKEEPER-445
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: BOOKKEEPER-445.patch, BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-445) LOG.trace calls in Bookie.java
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497253#comment-13497253 ]
Flavio Junqueira commented on BOOKKEEPER-445:
---------------------------------------------
Ok, I missed that. How does it work exactly? If I have "{}" in the log message, then it introduces the if check automatically?
> LOG.trace calls in Bookie.java
> ------------------------------
>
> Key: BOOKKEEPER-445
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-445
> Project: Bookkeeper
> Issue Type: Improvement
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
> Attachments: BOOKKEEPER-445.patch, BOOKKEEPER-445.patch
>
>
> I suggest we put them in an if block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira