You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/12/08 09:27:30 UTC
[PR] rework noisy dns log (#835) [incubator-pekko]
pjfanning opened a new pull request, #836:
URL: https://github.com/apache/incubator-pekko/pull/836
cherry pick f6af100531e037b4f245f564d7be8c70f0093a4f #835 #834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] rework noisy dns log (#835) [incubator-pekko]
Posted by "SakulK (via GitHub)" <gi...@apache.org>.
SakulK commented on PR #836:
URL: https://github.com/apache/incubator-pekko/pull/836#issuecomment-1853339363
This log wasn't happening with Akka, so during migration to Pekko it got me worried that something is broken (especially since the log level is `WARN`). So I guess this PR would revert an observable difference between Akka and Pekko 1.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] rework noisy dns log (#835) [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #836:
URL: https://github.com/apache/incubator-pekko/pull/836#issuecomment-1852982327
I'll go with the concensus but this log is not an Akka log - it was added by https://github.com/apache/incubator-pekko/commit/c56edca78f775934ca081f7967175960a18cb99c
My opinion is that this log message is incorrect in what it says, is unnecessary and logs excessively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] rework noisy dns log (#835) [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #836:
URL: https://github.com/apache/incubator-pekko/pull/836#issuecomment-1852987332
So just to clarify, the change in https://github.com/apache/incubator-pekko/commit/c56edca78f775934ca081f7967175960a18cb99c modified the logging (so its now spitting more logs then it used to) and this cherry pick commit fixes that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] rework noisy dns log (#835) [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #836:
URL: https://github.com/apache/incubator-pekko/pull/836#issuecomment-1853372475
> This log wasn't happening with Akka, so during migration to Pekko it got me worried that something is broken (especially since the log level is `WARN`). So I guess this PR would revert an observable difference between Akka and Pekko 1.0.x
Thanks for confirming, in this case it's good to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] rework noisy dns log (#835) [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #836:
URL: https://github.com/apache/incubator-pekko/pull/836#issuecomment-1852953100
Hmm, is this needed for Pekko 1.0.x? Technically speaking it is a behavioural change and its not actually fixing any critical bugs/security fixes.
I would actually argue that such a change is **not** a good thing because if people migrate from Akka to Pekko 1.0.x and they suddenly see a difference in logs their initial assumption (even if incorrect) may be that Pekko might have "broken" something or their migration "didn't work".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] rework noisy dns log (#835) [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #836:
URL: https://github.com/apache/incubator-pekko/pull/836#issuecomment-1853002485
> So just to clarify, the change in [c56edca](https://github.com/apache/incubator-pekko/commit/c56edca78f775934ca081f7967175960a18cb99c) modified the logging (so its now spitting more logs then it used to) and this cherry pick commit fixes that?
Yes. The change in Pekko may the logs noisier. The log statement that I am modifying seems to be a copy paste with small mods from the previous case - but this case is basically the success path and it issues a warning log when nothing is wrong.
@SakulK you reported the original issue (#834) - would you be able to comment on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] rework noisy dns log (#835) [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #836:
URL: https://github.com/apache/incubator-pekko/pull/836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org