You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/08 10:10:13 UTC
[GitHub] [flink-table-store] tsreaper opened a new pull request, #84: [FLINK-27139] FileStoreCommitImpl#filterCommitted should exit when faced with expired files
tsreaper opened a new pull request, #84:
URL: https://github.com/apache/flink-table-store/pull/84
Currently it is possible for `FileStoreCommitImpl#filterCommitted` to check an expired snapshot, which throws `FileNotExists` exception. When faced with an expired file `FileStoreCommitImpl#filterCommitted` should exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #84: [FLINK-27139] FileStoreCommitImpl#filterCommitted should exit when faced with expired files
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #84:
URL: https://github.com/apache/flink-table-store/pull/84#discussion_r846014574
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java:
##########
@@ -129,8 +130,18 @@ public FileStoreCommit withLock(Lock lock) {
identifiers.put(committable.identifier(), committable);
}
- for (long id = latestSnapshotId; id >= Snapshot.FIRST_SNAPSHOT_ID; id--) {
+ for (long id = latestSnapshotId;
+ id >= Snapshot.FIRST_SNAPSHOT_ID && !identifiers.isEmpty();
Review Comment:
return at the begaining of the method?
```
if (committableList.isEmpty) {
return committableList;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #84: [FLINK-27139] FileStoreCommitImpl#filterCommitted should exit when faced with expired files
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #84:
URL: https://github.com/apache/flink-table-store/pull/84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org