You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/12/02 14:33:50 UTC
[GitHub] [zeppelin] Reamer opened a new pull request #3986: [ZEPPELIN-4385] Migrate to GitHub actions
Reamer opened a new pull request #3986:
URL: https://github.com/apache/zeppelin/pull/3986
### What is this PR for?
This PR will change the CI-System from Travis to GitHub Actions
Advantages:
- [high usage limits](https://docs.github.com/en/free-pro-team@latest/actions/reference/usage-limits-billing-and-administration#usage-limits)
- no CI Setup is needed by Contributors
- good integration with GitHub Pull request
disadvantage
- At the moment we have some flappy tests and external dependencies. Both can cause a failed tests, but we can not restart a single job only the whole workflow
### What type of PR is it?
- Improvement
### Todos
* [ ] - Discuss if the job splitting
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-4385
### How should this be tested?
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #3986: [ZEPPELIN-4385] Migrate to GitHub actions
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3986:
URL: https://github.com/apache/zeppelin/pull/3986#issuecomment-739949402
Thanks @Reamer for the great work, it is really helpful for the community. Does job splitting trigger multiple github actions and make the CI faster ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] asfgit closed pull request #3986: [ZEPPELIN-4385] Migrate to GitHub actions
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3986:
URL: https://github.com/apache/zeppelin/pull/3986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on pull request #3986: [ZEPPELIN-4385] Migrate to GitHub actions
Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3986:
URL: https://github.com/apache/zeppelin/pull/3986#issuecomment-741576306
LGTM， @Reamer We can merge it first so that it won't block other tickets, and we can improve it later if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3986: [ZEPPELIN-4385] Migrate to GitHub actions
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3986:
URL: https://github.com/apache/zeppelin/pull/3986#issuecomment-739900436
@zjffdu
Your feedback is very welcome. Any thoughts on splitting jobs into different workflows?
If there are no more comments, I will merge this PR into Master and Branch-0.9 on Wednesday(09.12)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3986: [ZEPPELIN-4385] Migrate to GitHub actions
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3986:
URL: https://github.com/apache/zeppelin/pull/3986#issuecomment-740019972
> Does job splitting trigger multiple github actions and make the CI faster ?
Yes and no. Yes, job splitting will trigger more workflows with fewer jobs, but they will not be faster.
Advantages:
- You can restart a workflow with only a few jobs if a single job in it failed.
Disadvantage:
- The overview of several workflow files is more difficult.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Leemoonsoo commented on pull request #3986: [ZEPPELIN-4385] Migrate to GitHub actions
Posted by GitBox <gi...@apache.org>.
Leemoonsoo commented on pull request #3986:
URL: https://github.com/apache/zeppelin/pull/3986#issuecomment-737357024
Wow. Thank @Reamer for working on this! +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3986: [ZEPPELIN-4385] Migrate to GitHub actions
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3986:
URL: https://github.com/apache/zeppelin/pull/3986#issuecomment-740528018
> > Do you know the purpose of the Jenkins-Job?
>
> You mean Jenkins-Job at ci-build.a.o (https://ci-builds.apache.org/job/Zeppelin/job/zeppelin-pull-request/)?
>
> The Jenkins job only runs a [travis_check.py](https://github.com/apache/zeppelin/blob/master/travis_check.py) script.
>
> The script checks build status of the 'from' repository of the pullrequest. (and the pullrequest build in travis-ci.org of each 'from' repository account).
>
> So, we can remove the Jenkins job, as well as travis_check.py script.
It would be nice if you could delete the Jenkins job and a possible webhook after the merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3986: [ZEPPELIN-4385] Migrate to GitHub actions
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3986:
URL: https://github.com/apache/zeppelin/pull/3986#issuecomment-737293146
Feedback is welcome. Perhaps someone can answer the questions in the TODO section.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer edited a comment on pull request #3986: [ZEPPELIN-4385] Migrate to GitHub actions
Posted by GitBox <gi...@apache.org>.
Reamer edited a comment on pull request #3986:
URL: https://github.com/apache/zeppelin/pull/3986#issuecomment-740019972
> Does job splitting trigger multiple github actions and make the CI faster ?
Yes and no. Yes, job splitting will trigger more workflows with fewer jobs, but they will not be faster.
Advantages:
- You can restart a workflow with only a few jobs if a single job in it failed.
Disadvantage:
- The overview of several workflow files is more difficult.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #3986: [ZEPPELIN-4385] Migrate to GitHub actions
Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3986:
URL: https://github.com/apache/zeppelin/pull/3986#issuecomment-739898666
@Leemoonsoo
Do you know the purpose of the Jenkins-Job?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Leemoonsoo commented on pull request #3986: [ZEPPELIN-4385] Migrate to GitHub actions
Posted by GitBox <gi...@apache.org>.
Leemoonsoo commented on pull request #3986:
URL: https://github.com/apache/zeppelin/pull/3986#issuecomment-740300205
> Do you know the purpose of the Jenkins-Job?
You mean Jenkins-Job at ci-build.a.o (https://ci-builds.apache.org/job/Zeppelin/job/zeppelin-pull-request/)?
The Jenkins job only runs a [travis_check.py](https://github.com/apache/zeppelin/blob/master/travis_check.py) script.
The script checks build status of the 'from' repository of the pullrequest. (and the pullrequest build in travis-ci.org of each 'from' repository account).
So, we can remove the Jenkins job, as well as travis_check.py script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org