You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/01/12 08:58:36 UTC
Re: Review Request 54649: Fixed minor argument style.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54649/
-----------------------------------------------------------
(Updated Jan. 12, 2017, 4:57 p.m.)
Review request for mesos, Benjamin Mahler and Guangya Liu.
Changes
-------
rebase
Repository: mesos
Description
-------
Make the sequence of method arguments consistent with others.
Diffs (updated)
-----
3rdparty/libprocess/Makefile.am 5e7fdd06ccbed50f248c81e9df1651a3702e7add
3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 49ad836d5fa3f84cdf5ae0e08f449cd7ef2537a1
3rdparty/libprocess/configure.ac 48e3b14e3a70e8b0dc416c35997e8784d3409772
3rdparty/libprocess/include/process/address.hpp 6b143c3d00c1d7ebd1697c26b6d312a64f30839a
3rdparty/libprocess/include/process/future.hpp 819ee5ceb8f2900087c2a06d5b1df0a1aeb413f6
3rdparty/libprocess/include/process/http.hpp e8f53bfac1cf1c0758ef662e78754e9246a41eea
3rdparty/libprocess/include/process/io.hpp b342333bc7f2ae12b5b6a92fa21896c8f42353cb
3rdparty/libprocess/include/process/loop.hpp 8bd9715246e72474a35a0f1af94c8a5a3e87dd7a
3rdparty/libprocess/include/process/process.hpp b118f1a2bf5aac12b53ae204253b88c9b1c65f46
3rdparty/libprocess/include/process/socket.hpp 87966155aa21328db51796b2ae0a883054c00457
3rdparty/libprocess/m4/ax_check_compile_flag.m4 51df0c09a7a8bf40dc11193559a45296545653c5
3rdparty/libprocess/src/http.cpp 8895f0cfadf1cca9714fc7110ed0914e3db18983
3rdparty/libprocess/src/io.cpp c37ec1811fab7d8d33f0d5fd8703ab121d6db514
3rdparty/libprocess/src/libevent_ssl_socket.hpp 65da091155107d77bdf7b003609ab3770f80083a
3rdparty/libprocess/src/libevent_ssl_socket.cpp b0319b2d3694f600190615ba6d29b95b1d8f2405
3rdparty/libprocess/src/process.cpp f475fe78f801924f70f51fdc4ab190c2dbecd656
3rdparty/libprocess/src/socket.cpp b819503095261c77f42d6f20d1a4b2b6170fb4e1
3rdparty/libprocess/src/tests/CMakeLists.txt 0b2660cb16f5d8d8dc66e6995061d0b832182351
3rdparty/libprocess/src/tests/benchmarks.cpp 8e8f426d3c8ba52f6c91b97fbff8702b9a6f2095
3rdparty/libprocess/src/tests/future_tests.cpp 380755f9a2329d548969cfb2332c79aacbf7fff2
3rdparty/libprocess/src/tests/http_tests.cpp 6abc096ec230aee3ced7b99a43147b3423f83920
3rdparty/libprocess/src/tests/io_tests.cpp 5c889e97cb1402a98b27cad2f3dbb4047a995506
3rdparty/libprocess/src/tests/loop_tests.cpp 8d1837a0baedc12591f92c8f0f8ea83d0aa44ab0
3rdparty/stout/Makefile.am ebf1069eb1b787f063a2066a4db0b3f5de4a56da
3rdparty/stout/cmake/FindApr.cmake 13156a58a57c22044977c7220df31372e61f82f6
3rdparty/stout/cmake/FindSvn.cmake d57eed98285295bcc845bb0494c86e3866685690
3rdparty/stout/cmake/StoutConfigure.cmake bc27ac687bae4e1798eece562027ba33c6b32348
3rdparty/stout/cmake/StoutTestsConfigure.cmake d3bd72e8eba77213095da6cabb3a6d6f4d30941c
3rdparty/stout/configure.ac cac14577caa9085728f89af9f7511c45ee37f78d
3rdparty/stout/include/stout/flags/flags.hpp 4de093d675b094a438e38ecbc867837f7cbc5f7c
3rdparty/stout/include/stout/gzip.hpp 7040a3275370e7447e843c2471f35e2ba26166e4
3rdparty/stout/include/stout/json.hpp b0fd667cdb004995553f961de24a168b09397948
3rdparty/stout/include/stout/jsonify.hpp 3c48046e087de2a66139a31449327fd94c149371
3rdparty/stout/include/stout/os.hpp ed6fec3ac1c1f9dfb0585178401f4b552822a0a1
3rdparty/stout/include/stout/os/mkdir.hpp b384391a96438558e34b88884992c84dcdf720d6
3rdparty/stout/include/stout/os/osx.hpp 504af3e650ab680d65107448b302ca7cf99e9ad6
3rdparty/stout/include/stout/os/permissions.hpp 453e60c7268db516c2c94501e11a92fe8f490498
3rdparty/stout/include/stout/os/posix/socket.hpp 041f00083c595c335146048c8685c4f96226b8e8
3rdparty/stout/include/stout/os/posix/su.hpp cb1478b6b7710b7d5a916f860a826df4d781e056
3rdparty/stout/include/stout/os/posix/xattr.hpp 6913c1529007cc1431a370a9cc97b8af5807d463
3rdparty/stout/include/stout/path.hpp 2d2088aadfa1ea82c59424242671c4fb655dede1
3rdparty/stout/include/stout/try.hpp 90f8aed56ce5d77e70af9e516faad152083d1488
3rdparty/stout/m4/ax_check_compile_flag.m4 51df0c09a7a8bf40dc11193559a45296545653c5
3rdparty/stout/tests/CMakeLists.txt a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae
3rdparty/stout/tests/ip_tests.cpp 930365bc4d431682c681dab5f4f05a8521d42a41
3rdparty/stout/tests/os_tests.cpp 30735e28a26ff713469711d63538676ed4e327d9
CHANGELOG cad0a1444a0b6bba04996a194ff965eee43c4daa
cmake/CompilationConfigure.cmake 560935b81603dc58c167918d36e2ae0a4060673d
configure.ac 60ffa0e6a0dc590af929ab8a011b6d78f82a48e0
docs/committers.md 2d284ba42214567fa013f71a906fbbb72237b47e
docs/configuration.md 2113d06f58dddc0a28ae1241a24096266fe39801
docs/contributors.yaml caaf56f6eeede7e9abe9c80ea52ba96334204ef6
docs/endpoints/index.md eb88154aaa46c340112acee149c716cf32a495bb
docs/endpoints/master/slaves.md ae214d849bb2a737dc42916dd7a262f2abf9a590
docs/logging.md 75c438570694c974c077296d925059469b4d344c
docs/operator-http-api.md 3a534ca7e64e3adc7a8782828ddfe5b675f5812e
docs/powered-by-mesos.md 669c183ddd30556849b0a95bdb854e2d5e84bc1a
include/mesos/master/master.proto 03203c8ddd05876339b1c56789b7bb140499d49d
include/mesos/mesos.proto ab68ff85c4af5d254779b30a7f27eda9fcb790eb
include/mesos/slave/isolator.hpp c52563fa055ae4d949f40db53c0f2eaec1cf9036
include/mesos/v1/master/master.proto f8edf39a68752c8601cece345f52bce8b9a8a68b
include/mesos/v1/mesos.proto caefa239be6ead10b9a5fc91ba120ea9c8775313
m4/ax_check_compile_flag.m4 51df0c09a7a8bf40dc11193559a45296545653c5
src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c
src/Makefile.am 333b45683a10eaac3b653e006511306d8054922c
src/common/http.cpp c65c79e3f689b32fb9e62062fbc297b10501dcfe
src/common/recordio.hpp 378363492e04c141671fbed0467bf558b61e5dae
src/common/resources.cpp be9bca2063e9f0e60c5faa0142077bea56272e45
src/docker/docker.cpp b63b060ba1c1d39dc1702368cf667831edbd39bd
src/examples/long_lived_framework.cpp bbe8606c8d2572bbbbad695e44fa23ce7b6129eb
src/examples/test_framework.cpp 068b85d551012a390ba2a68bc88807103d3c31f3
src/examples/test_http_framework.cpp 258cb512803d1ed07c7a5ce1465e5663e77b0977
src/launcher/default_executor.cpp 57e4799e750f8f5352a9fec58af40efe432ea865
src/launcher/executor.cpp e035a4ee4438a3342f68a5548a5fd8d57a315cfa
src/launcher/posix/executor.cpp 4bc0b0f1a09bf1579ff9612f812f09a3061883ce
src/master/cmake/MasterConfigure.cmake 3d316d6ff2910fc360b0faecb5e6ac9687a77883
src/master/contender/contender.cpp cc486a176d14e61a2434ce3677c8741963a39057
src/master/flags.cpp 124bfbca6be9d5d60597b9a1793bd807202da8ec
src/master/http.cpp 75dcd6199dbfcca6260baed49b838a45312bb667
src/master/master.hpp 368ee1d5e97784fa54e0f141906405ee8f104317
src/master/master.cpp 1746a88953dbdc148d98881bcf7027b62ad6b040
src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f
src/module/manager.hpp f38f5873d93dcd95dbb8a72446a2f97bdc80e088
src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193
src/python/setup.py.in 991ac31409c566e8a59d47f8296317e245925d4e
src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644
src/slave/cmake/AgentConfigure.cmake 1582127ccce773af6031a5b09252192b05a13cdc
src/slave/container_loggers/lib_logrotate.hpp e37d99cb268bb3286e312d2ebdbaf84d3fd4bf91
src/slave/container_loggers/lib_logrotate.cpp b257f48f819985e339a5a7fd8066ffa9f39df7a6
src/slave/container_loggers/logrotate.hpp 1fce8e3528e55aff798fbbf056bf6d9ed2142255
src/slave/containerizer/fetcher.cpp ba2e118bdefa932aa4109452548faf6cafb3451f
src/slave/containerizer/mesos/containerizer.cpp 8b97dc4980e9581c21e59e290f2f736398b5b955
src/slave/containerizer/mesos/io/switchboard.cpp 2c4eed8f2dc7f91b9fd08f91f1b08484fca9a9af
src/slave/containerizer/mesos/isolators/appc/runtime.cpp 9bc3fd8309435846c17944e74f611212069dbd76
src/slave/containerizer/mesos/isolators/docker/runtime.cpp 2d816e512c95ed2922c9578ba796908c5ce23da4
src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 4df69ab98244f2475e6b5330f374bb58159eca41
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ea91c71fdfac48a2fc1d31a0ee088a73244be367
src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp ab4b88acddc7503e16e3730320df39a2f104539a
src/slave/containerizer/mesos/provisioner/appc/cache.hpp f00abe7901431d1b8f3716ad6983327ae6dc0672
src/slave/containerizer/mesos/provisioner/appc/cache.cpp fed5ae97419d5eb9611a6fd1ade1bbed7ed440a2
src/slave/containerizer/mesos/provisioner/provisioner.cpp 519028236305e9c8c1b6cded1919a5dd7ca3dbed
src/slave/http.cpp 24fc23b229c624835a24cdda9587c99c6ac9c3bb
src/slave/main.cpp e1fbc80476f78a302c11b3a456fa0b1761328688
src/slave/slave.hpp acb4f6581fcf22f9a748f6ccea48665542e76bc3
src/slave/slave.cpp 11e8833fd5998abb71a7bb08e5dec451d894aba9
src/slave/state.hpp a497ce1f58fb8dc7718ee5bb10bc62dd7479efa5
src/slave/state.cpp 6894875b37b7a34c8f3645087404584bbe982e6c
src/state/zookeeper.cpp 1abd81651d575558f18001de89e9abef3a80caf4
src/tests/CMakeLists.txt b7adf4f3126611a57baf4f62b62b208bc0236da5
src/tests/api_tests.cpp ea62226fbc5dd0bcc5ea60d1bbcd3748f9367467
src/tests/cmake/MesosTestsConfigure.cmake 8d416388a8e45a2832ae3841b58541ba5b0613bc
src/tests/container_logger_tests.cpp 7ac83338b5944967d0cbe768bf622c654fee99e1
src/tests/containerizer/capabilities_test_helper.cpp 4ed76c6ad8ed2c75adcc2517a5e7601e746b4363
src/tests/containerizer/cni_isolator_tests.cpp 82697aea98add4adc2cf7eac5f30dd9b467803c9
src/tests/containerizer/docker_containerizer_tests.cpp fa734e6b4b5d61e944cd70f1378f2d2eb534fe22
src/tests/containerizer/io_switchboard_tests.cpp 256ec1faa96e67a831d75c588f25a343a1cbbb21
src/tests/containerizer/isolator.hpp f31cf6d141af752f8165e52ca7472c543f568d92
src/tests/containerizer/provisioner_appc_tests.cpp 4d4ebba92ae66767903edc7a4f6edd9c6fee2489
src/tests/containerizer/runtime_isolator_tests.cpp 1c1f7befc9e7ad38c8259f87a21656b003971b46
src/tests/default_executor_tests.cpp ec3e854ed58a0fbb3bfad0bd21eb0e2974548865
src/tests/environment.cpp df92679d39d858c2d811b570fac8c853c399503e
src/tests/fault_tolerance_tests.cpp b13a7e2527189931b733fb4f188b1463fe1f919a
src/tests/log_tests.cpp 72182d39aa4e9d092b829316cf7214dbe7b7e98e
src/tests/master_allocator_tests.cpp 996762f25453f7a8a5e0b7b97006ee2a603cf8c4
src/tests/master_tests.cpp da7094dbbafbb0ab1153a0a4a6fcabd63888d67a
src/tests/mesos.hpp 71e919702bccd31bf1e14205cd1e30d473883d48
src/tests/oversubscription_tests.cpp 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25
src/tests/partition_tests.cpp 72013d1bfee275c6f3cb90173f0c408d55e0bc5d
src/tests/persistent_volume_endpoints_tests.cpp 1d40380dedbd6f0e1402b9a37d8a231cf73881f7
src/tests/persistent_volume_tests.cpp 8198b6b5ad323d17835ba067c7ff3d34ef948125
src/tests/reconciliation_tests.cpp fc0ff9137c13f839731d8f228423b05f386463b5
src/tests/registrar_tests.cpp 73cc25cf0868080ce4cb577e5b3001a2cad7e123
src/tests/reservation_endpoints_tests.cpp d94fe29e5972e6ed0011ca00cc56fe1c20cda495
src/tests/reservation_tests.cpp b7061de0dfcc79548d507c7d70376c82d5d647ec
src/tests/slave_recovery_tests.cpp 9323cbb74dd555fe6c44af1ef6da70e0c2d76dcb
src/tests/slave_tests.cpp 152c53ff102a081ce5c3b74984720fda8b791811
src/tests/slave_validation_tests.cpp 5de771114982751e7796f55dcacd4384c6989efb
src/v1/resources.cpp da4701c03020ff9c33ef995cd0af437d8827c267
src/webui/master/static/fonts/glyphicons-halflings-regular.woff2 64539b54c3751a6d9adb44c8e3a45ba5a73b77f0
src/webui/master/static/ico/favicon.ico 11dd3de5f124550be141bce9a9a96a516a9c9b7b
src/zookeeper/zookeeper.cpp 5ede4e5c47b30693ef9f296777dea8db2c4a48d8
support/apply-reviews.py b9b978af6ea59075c2d497a222e6c2961367022a
support/generate-endpoint-help.py 6eb2d41b35c5f064839c29a0ba8326c590a33213
support/mesos-tidy.sh 98ea3857572942536c4f37579ec3f1cae64aaaf7
support/verify_reviews.py fadf8b9d9374664d9c27f61c8fe1f7fcd9690e9b
support/windows-build.bat 4af5ae3fc009b895121b7a4c82db132a4809f211
Diff: https://reviews.apache.org/r/54649/diff/
Testing
-------
Thanks,
Jay Guo
Re: Review Request 54649: Fixed minor argument style.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54649/#review161956
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Jan. 12, 2017, 9:04 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54649/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 9:04 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make the sequence of method arguments consistent with others.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f
>
> Diff: https://reviews.apache.org/r/54649/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 54649: Fixed minor argument style.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54649/
-----------------------------------------------------------
(Updated Jan. 12, 2017, 5:04 p.m.)
Review request for mesos, Benjamin Mahler and Guangya Liu.
Changes
-------
rebase
Repository: mesos
Description
-------
Make the sequence of method arguments consistent with others.
Diffs (updated)
-----
src/master/validation.cpp 96aa36585ded4bd7cf98526f710ccbc4f23b1f0f
Diff: https://reviews.apache.org/r/54649/diff/
Testing
-------
Thanks,
Jay Guo