You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/30 20:47:17 UTC

[GitHub] [kafka] abbccdda commented on a change in pull request #9096: MINOR: Add comments to constrainedAssign and generalAssign method

abbccdda commented on a change in pull request #9096:
URL: https://github.com/apache/kafka/pull/9096#discussion_r463260878



##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##########
@@ -163,6 +183,7 @@ private boolean allSubscriptionsEqual(Set<String> allTopics,
         Map<String, List<TopicPartition>> assignment = new HashMap<>(
             consumerToOwnedPartitions.keySet().stream().collect(Collectors.toMap(c -> c, c -> new ArrayList<>(minQuota))));
 
+        // step 1: Reassign as many previously owned partitions as possible

Review comment:
       nit: I don't think we need steps here, which makes it hard to squeeze in more comments later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org