You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sachingoel0101 <gi...@git.apache.org> on 2015/11/28 12:46:02 UTC

[GitHub] flink pull request: [FLINK-3056][web-dashboard] Represent bytes in...

GitHub user sachingoel0101 opened a pull request:

    https://github.com/apache/flink/pull/1419

    [FLINK-3056][web-dashboard] Represent bytes in more readable form.

    Bytes are now displayed in the following fashion:
    1. For [0, 1000) units, display three significant digits.
    2. For [1000,1024) units, display 2 decimal points for the next higher unit.
    For example, 1010 KB is displayed as 0.99 MB, 10 MB is displayed as 10.0 MB and 230 MB is displayed as such.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sachingoel0101/flink 3056-ui-bytes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1419.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1419
    
----
commit fc65aa4287689e05cd00fde82e2acbc45f28e854
Author: Sachin Goel <sa...@gmail.com>
Date:   2015-11-28T11:24:23Z

    [FLINK-3056][web-dashboard] Represent bytes in more readable form.
    Bytes are now displayed in the following fashion:
    1. For [0, 1000) units, display three significant digits.
    2. For [1000,1024) units, display 2 decimal points for the next higher unit.
    For example, 1010 KB is displayed as 0.99 MB, 10 MB is displayed as 10.0 MB and 230 MB is displayed as such.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3056][web-dashboard] Represent bytes in...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1419#issuecomment-160652484
  
    Merging this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3056][web-dashboard] Represent bytes in...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1419


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3056][web-dashboard] Represent bytes in...

Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1419#issuecomment-160419611
  
    +1 to merge
    
    Validated the change on a cluster and it worked nicely: 
    ![image](https://cloud.githubusercontent.com/assets/89049/11457652/e02cff9e-96ae-11e5-806a-48b55ff17b1a.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---