You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@corinthia.apache.org by "Dennis E. Hamilton" <de...@acm.org> on 2014/12/21 17:19:11 UTC
RE: [51/51] [partial] incubator-corinthia git commit: Moved 3rdparty to platform ...
It might have been much safer to work this out on a branch first [;<).
-----Original Message-----
From: jani@apache.org [mailto:jani@apache.org]
Sent: Sunday, December 21, 2014 04:36
To: commits@corinthia.incubator.apache.org
Subject: [51/51] [partial] incubator-corinthia git commit: Moved 3rdparty to platform This is the first part of isolating 3rdparty within platform. The idea is that only platform.h should be used outside platform platform.h might contain includes to internal file
Moved 3rdparty to platform
This is the first part of isolating 3rdparty within platform.
The idea is that only platform.h should be used outside platform
platform.h might contain includes to internal files in platform.h, but no other source should.
Project: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/commit/ac70cb0e
Tree: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/tree/ac70cb0e
Diff: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/diff/ac70cb0e
Branch: refs/heads/master
Commit: ac70cb0ed455af39c40fe903b4e323fe82da0d04
Parents: af9830b
Author: jani <ja...@apache.org>
Authored: Sun Dec 21 13:32:01 2014 +0100
Committer: jani <ja...@apache.org>
Committed: Sun Dec 21 13:32:01 2014 +0100
[ ... ]
Re: [51/51] [partial] incubator-corinthia git commit: Moved 3rdparty
to platform ...
Posted by jan i <ja...@apache.org>.
On 21 December 2014 at 22:51, Daniel Gruno <hu...@apache.org> wrote:
> #corinthia is fine, the #apache- prefix we sometimes use is a safeguard,
> as we own that namespace on Freenode.
> I have registered #corinthia now, so there should be no issues.
>
I am not constantly online on IRC for the time being, but that can change.
I tend to use google hangout or skype....as well as hipchat (for infra).
These channels can also be saved.
But I go with the majority, so if we agree on IRC I will be there as well.
rgds
jan i.
>
> With regards,
> Daniel.
>
>
> On 2014-12-21 22:43, Louis Suárez-Potts wrote:
>
>> Jan, I know you dislike IRC and for aught I know, so too the rest of us,
>> save I.
>>
>> But keeping an IRC window open for casual discourse is useful. Also it
>> can be saved and posted to the mail lists, if that is desired.
>>
>> Do we have a channel yet on Freenode? If not, I can create one, I think,
>> #corinthia, or ought it include Apache, as: #apache_corinthia?
>>
>> louis
>>
>>
>> On 21 Dec 2014, at 16:38, jan i <ja...@apache.org> wrote:
>>>
>>> On Sunday, December 21, 2014, Dennis E. Hamilton <
>>> dennis.hamilton@acm.org>
>>> wrote:
>>>
>>> OK, I didn’t realize you had it running. I thought your Windows-build
>>>> concern was with these.
>>>>
>>>> Warning would have been good though [;<).
>>>>
>>> sorry you are right.
>>>
>>> so for reference the next week or so I will be modifying cmake files so
>>> the
>>> logical entities (eg. platform) show as one in visual study.
>>>
>>> I will also work on limiting all 3rdparty things to be inside platform,
>>> which means writing a couple of cover functions.
>>>
>>> I will release the code in steps, whenever a part is ready, in order not
>>> to
>>> limit the work of everybody else.
>>>
>>> I’ll sync now.
>>>>
>>>> - Dennis
>>>>
>>>> PS: You don’t have to keep copying me directly. I watch the list quite
>>>> religiously.
>>>>
>>> I just say reply all, but this time I removed your email, let me see if
>>> it
>>> happens again.
>>>
>>> rgds
>>> jan i
>>>
>>> -- in reply to --
>>>> From: jan i [mailto:jani@apache.org <javascript:;>]
>>>> Sent: Sunday, December 21, 2014 09:57
>>>> To: dev@corinthia.incubator.apache.org <javascript:;>;
>>>> dennis.hamilton@acm.org <javascript:;>
>>>> Subject: Re: [51/51] [partial] incubator-corinthia git commit: Moved
>>>> 3rdparty to platform ...
>>>>
>>>>
>>>>
>>>> On Sunday, December 21, 2014, Dennis E. Hamilton <
>>>> dennis.hamilton@acm.org
>>>> <javascript:;>> wrote:
>>>> It might have been much safer to work this out on a branch first [;<)
>>>>
>>>> what do you mean ?
>>>>
>>>> I had it running in a branch before i merged it to master and pushed it.
>>>>
>>>> I never work directly on master. But this change blocks for other people
>>>> working so I have to release it in parts.
>>>>
>>>> rgds
>>>> jan i
>>>> .
>>>> [ … ]
>>>>
>>>>
>>>> --
>>> Sent from My iPad, sorry for any misspellings.
>>>
>>
>
Re: [51/51] [partial] incubator-corinthia git commit: Moved 3rdparty to platform ...
Posted by Louis Suárez-Potts <lu...@gmail.com>.
> On 21 Dec 2014, at 16:51, Daniel Gruno <hu...@apache.org> wrote:
>
> #corinthia is fine, the #apache- prefix we sometimes use is a safeguard, as we own that namespace on Freenode.
> I have registered #corinthia now, so there should be no issues.
Thanks
(Now I just got to get me there.)
louis
>
> With regards,
> Daniel.
>
> On 2014-12-21 22:43, Louis Suárez-Potts wrote:
>> Jan, I know you dislike IRC and for aught I know, so too the rest of us, save I.
>>
>> But keeping an IRC window open for casual discourse is useful. Also it can be saved and posted to the mail lists, if that is desired.
>>
>> Do we have a channel yet on Freenode? If not, I can create one, I think, #corinthia, or ought it include Apache, as: #apache_corinthia?
>>
>> louis
>>
>>
>>> On 21 Dec 2014, at 16:38, jan i <ja...@apache.org> wrote:
>>>
>>> On Sunday, December 21, 2014, Dennis E. Hamilton <de...@acm.org>
>>> wrote:
>>>
>>>> OK, I didn’t realize you had it running. I thought your Windows-build
>>>> concern was with these.
>>>>
>>>> Warning would have been good though [;<).
>>> sorry you are right.
>>>
>>> so for reference the next week or so I will be modifying cmake files so the
>>> logical entities (eg. platform) show as one in visual study.
>>>
>>> I will also work on limiting all 3rdparty things to be inside platform,
>>> which means writing a couple of cover functions.
>>>
>>> I will release the code in steps, whenever a part is ready, in order not to
>>> limit the work of everybody else.
>>>
>>>> I’ll sync now.
>>>>
>>>> - Dennis
>>>>
>>>> PS: You don’t have to keep copying me directly. I watch the list quite
>>>> religiously.
>>> I just say reply all, but this time I removed your email, let me see if it
>>> happens again.
>>>
>>> rgds
>>> jan i
>>>
>>>> -- in reply to --
>>>> From: jan i [mailto:jani@apache.org <javascript:;>]
>>>> Sent: Sunday, December 21, 2014 09:57
>>>> To: dev@corinthia.incubator.apache.org <javascript:;>;
>>>> dennis.hamilton@acm.org <javascript:;>
>>>> Subject: Re: [51/51] [partial] incubator-corinthia git commit: Moved
>>>> 3rdparty to platform ...
>>>>
>>>>
>>>>
>>>> On Sunday, December 21, 2014, Dennis E. Hamilton <dennis.hamilton@acm.org
>>>> <javascript:;>> wrote:
>>>> It might have been much safer to work this out on a branch first [;<)
>>>>
>>>> what do you mean ?
>>>>
>>>> I had it running in a branch before i merged it to master and pushed it.
>>>>
>>>> I never work directly on master. But this change blocks for other people
>>>> working so I have to release it in parts.
>>>>
>>>> rgds
>>>> jan i
>>>> .
>>>> [ … ]
>>>>
>>>>
>>> --
>>> Sent from My iPad, sorry for any misspellings.
>
Re: [51/51] [partial] incubator-corinthia git commit: Moved 3rdparty
to platform ...
Posted by Daniel Gruno <hu...@apache.org>.
#corinthia is fine, the #apache- prefix we sometimes use is a safeguard,
as we own that namespace on Freenode.
I have registered #corinthia now, so there should be no issues.
With regards,
Daniel.
On 2014-12-21 22:43, Louis Suárez-Potts wrote:
> Jan, I know you dislike IRC and for aught I know, so too the rest of us, save I.
>
> But keeping an IRC window open for casual discourse is useful. Also it can be saved and posted to the mail lists, if that is desired.
>
> Do we have a channel yet on Freenode? If not, I can create one, I think, #corinthia, or ought it include Apache, as: #apache_corinthia?
>
> louis
>
>
>> On 21 Dec 2014, at 16:38, jan i <ja...@apache.org> wrote:
>>
>> On Sunday, December 21, 2014, Dennis E. Hamilton <de...@acm.org>
>> wrote:
>>
>>> OK, I didn’t realize you had it running. I thought your Windows-build
>>> concern was with these.
>>>
>>> Warning would have been good though [;<).
>> sorry you are right.
>>
>> so for reference the next week or so I will be modifying cmake files so the
>> logical entities (eg. platform) show as one in visual study.
>>
>> I will also work on limiting all 3rdparty things to be inside platform,
>> which means writing a couple of cover functions.
>>
>> I will release the code in steps, whenever a part is ready, in order not to
>> limit the work of everybody else.
>>
>>> I’ll sync now.
>>>
>>> - Dennis
>>>
>>> PS: You don’t have to keep copying me directly. I watch the list quite
>>> religiously.
>> I just say reply all, but this time I removed your email, let me see if it
>> happens again.
>>
>> rgds
>> jan i
>>
>>> -- in reply to --
>>> From: jan i [mailto:jani@apache.org <javascript:;>]
>>> Sent: Sunday, December 21, 2014 09:57
>>> To: dev@corinthia.incubator.apache.org <javascript:;>;
>>> dennis.hamilton@acm.org <javascript:;>
>>> Subject: Re: [51/51] [partial] incubator-corinthia git commit: Moved
>>> 3rdparty to platform ...
>>>
>>>
>>>
>>> On Sunday, December 21, 2014, Dennis E. Hamilton <dennis.hamilton@acm.org
>>> <javascript:;>> wrote:
>>> It might have been much safer to work this out on a branch first [;<)
>>>
>>> what do you mean ?
>>>
>>> I had it running in a branch before i merged it to master and pushed it.
>>>
>>> I never work directly on master. But this change blocks for other people
>>> working so I have to release it in parts.
>>>
>>> rgds
>>> jan i
>>> .
>>> [ … ]
>>>
>>>
>> --
>> Sent from My iPad, sorry for any misspellings.
Re: [51/51] [partial] incubator-corinthia git commit: Moved 3rdparty to platform ...
Posted by Louis Suárez-Potts <lu...@gmail.com>.
Jan, I know you dislike IRC and for aught I know, so too the rest of us, save I.
But keeping an IRC window open for casual discourse is useful. Also it can be saved and posted to the mail lists, if that is desired.
Do we have a channel yet on Freenode? If not, I can create one, I think, #corinthia, or ought it include Apache, as: #apache_corinthia?
louis
> On 21 Dec 2014, at 16:38, jan i <ja...@apache.org> wrote:
>
> On Sunday, December 21, 2014, Dennis E. Hamilton <de...@acm.org>
> wrote:
>
>> OK, I didn’t realize you had it running. I thought your Windows-build
>> concern was with these.
>>
>> Warning would have been good though [;<).
>
> sorry you are right.
>
> so for reference the next week or so I will be modifying cmake files so the
> logical entities (eg. platform) show as one in visual study.
>
> I will also work on limiting all 3rdparty things to be inside platform,
> which means writing a couple of cover functions.
>
> I will release the code in steps, whenever a part is ready, in order not to
> limit the work of everybody else.
>
>>
>> I’ll sync now.
>>
>> - Dennis
>>
>> PS: You don’t have to keep copying me directly. I watch the list quite
>> religiously.
>
> I just say reply all, but this time I removed your email, let me see if it
> happens again.
>
> rgds
> jan i
>
>>
>> -- in reply to --
>> From: jan i [mailto:jani@apache.org <javascript:;>]
>> Sent: Sunday, December 21, 2014 09:57
>> To: dev@corinthia.incubator.apache.org <javascript:;>;
>> dennis.hamilton@acm.org <javascript:;>
>> Subject: Re: [51/51] [partial] incubator-corinthia git commit: Moved
>> 3rdparty to platform ...
>>
>>
>>
>> On Sunday, December 21, 2014, Dennis E. Hamilton <dennis.hamilton@acm.org
>> <javascript:;>> wrote:
>> It might have been much safer to work this out on a branch first [;<)
>>
>> what do you mean ?
>>
>> I had it running in a branch before i merged it to master and pushed it.
>>
>> I never work directly on master. But this change blocks for other people
>> working so I have to release it in parts.
>>
>> rgds
>> jan i
>> .
>> [ … ]
>>
>>
>
> --
> Sent from My iPad, sorry for any misspellings.
Re: [51/51] [partial] incubator-corinthia git commit: Moved 3rdparty
to platform ...
Posted by jan i <ja...@apache.org>.
On Sunday, December 21, 2014, Dennis E. Hamilton <de...@acm.org>
wrote:
> OK, I didn’t realize you had it running. I thought your Windows-build
> concern was with these.
>
> Warning would have been good though [;<).
sorry you are right.
so for reference the next week or so I will be modifying cmake files so the
logical entities (eg. platform) show as one in visual study.
I will also work on limiting all 3rdparty things to be inside platform,
which means writing a couple of cover functions.
I will release the code in steps, whenever a part is ready, in order not to
limit the work of everybody else.
>
> I’ll sync now.
>
> - Dennis
>
> PS: You don’t have to keep copying me directly. I watch the list quite
> religiously.
I just say reply all, but this time I removed your email, let me see if it
happens again.
rgds
jan i
>
> -- in reply to --
> From: jan i [mailto:jani@apache.org <javascript:;>]
> Sent: Sunday, December 21, 2014 09:57
> To: dev@corinthia.incubator.apache.org <javascript:;>;
> dennis.hamilton@acm.org <javascript:;>
> Subject: Re: [51/51] [partial] incubator-corinthia git commit: Moved
> 3rdparty to platform ...
>
>
>
> On Sunday, December 21, 2014, Dennis E. Hamilton <dennis.hamilton@acm.org
> <javascript:;>> wrote:
> It might have been much safer to work this out on a branch first [;<)
>
> what do you mean ?
>
> I had it running in a branch before i merged it to master and pushed it.
>
> I never work directly on master. But this change blocks for other people
> working so I have to release it in parts.
>
> rgds
> jan i
> .
> [ … ]
>
>
--
Sent from My iPad, sorry for any misspellings.
RE: [51/51] [partial] incubator-corinthia git commit: Moved 3rdparty to platform ...
Posted by "Dennis E. Hamilton" <de...@acm.org>.
OK, I didn’t realize you had it running. I thought your Windows-build concern was with these.
Warning would have been good though [;<).
I’ll sync now.
- Dennis
PS: You don’t have to keep copying me directly. I watch the list quite religiously.
-- in reply to --
From: jan i [mailto:jani@apache.org]
Sent: Sunday, December 21, 2014 09:57
To: dev@corinthia.incubator.apache.org; dennis.hamilton@acm.org
Subject: Re: [51/51] [partial] incubator-corinthia git commit: Moved 3rdparty to platform ...
On Sunday, December 21, 2014, Dennis E. Hamilton <de...@acm.org> wrote:
It might have been much safer to work this out on a branch first [;<)
what do you mean ?
I had it running in a branch before i merged it to master and pushed it.
I never work directly on master. But this change blocks for other people working so I have to release it in parts.
rgds
jan i
.
[ … ]
Re: [51/51] [partial] incubator-corinthia git commit: Moved 3rdparty
to platform ...
Posted by jan i <ja...@apache.org>.
On Sunday, December 21, 2014, Dennis E. Hamilton <de...@acm.org>
wrote:
> It might have been much safer to work this out on a branch first [;<)
what do you mean ?
I had it running in a branch before i merged it to master and pushed it.
I never work directly on master. But this change blocks for other people
working so I have to release it in parts.
rgds
jan i
> .
>
> -----Original Message-----
> From: jani@apache.org <javascript:;> [mailto:jani@apache.org
> <javascript:;>]
> Sent: Sunday, December 21, 2014 04:36
> To: commits@corinthia.incubator.apache.org <javascript:;>
> Subject: [51/51] [partial] incubator-corinthia git commit: Moved 3rdparty
> to platform This is the first part of isolating 3rdparty within platform.
> The idea is that only platform.h should be used outside platform platform.h
> might contain includes to internal file
>
> Moved 3rdparty to platform
> This is the first part of isolating 3rdparty within platform.
> The idea is that only platform.h should be used outside platform
> platform.h might contain includes to internal files in platform.h, but no
> other source should.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-corinthia/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/incubator-corinthia/commit/ac70cb0e
> Tree:
> http://git-wip-us.apache.org/repos/asf/incubator-corinthia/tree/ac70cb0e
> Diff:
> http://git-wip-us.apache.org/repos/asf/incubator-corinthia/diff/ac70cb0e
>
> Branch: refs/heads/master
> Commit: ac70cb0ed455af39c40fe903b4e323fe82da0d04
> Parents: af9830b
> Author: jani <jani@apache.org <javascript:;>>
> Authored: Sun Dec 21 13:32:01 2014 +0100
> Committer: jani <jani@apache.org <javascript:;>>
> Committed: Sun Dec 21 13:32:01 2014 +0100
>
> [ ... ]
>
>
--
Sent from My iPad, sorry for any misspellings.