You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/09/16 12:10:28 UTC

[GitHub] [hive] deniskuzZ commented on a change in pull request #2642: Hive 25518 compaction txn handle NPE fix

deniskuzZ commented on a change in pull request #2642:
URL: https://github.com/apache/hive/pull/2642#discussion_r710056104



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -585,6 +584,12 @@ protected Boolean findNextCompactionAndExecute(boolean computeStats) {
     return true;
   }
 
+  @VisibleForTesting
+  public CompactionInfo nextCompactForWorkerAndRuntime() throws TException {

Review comment:
       could we please rename it to 'getNextCompactRequest'




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org