You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/09 12:05:52 UTC
[GitHub] [flink] xuyangzhong opened a new pull request #17444: [FLINK-24492]incorrect implicit type conversion between numeric and (var)char
xuyangzhong opened a new pull request #17444:
URL: https://github.com/apache/flink/pull/17444
## What is the purpose of the change
Before, the result of the sql "select 1 = '1'" is false, which is wrong. And when "1 = '1'" is in join conditions, it will throw an exception, instead of returning a true or false result.
"=" should have the same behavior with ">" and "<", which have the correct results. So before calcite solves this bug or Flink supports this kind of implicit type conversion, we'd better temporarily forbidding this implicit type conversion in "=" and "<>" and all throwing a clear exception, instead of giving a wrong result.
## Brief change log
- In the codegen function, check the validity of implicit type conversion to avoid conversion between numeric and (var)char.
- According to flip-154, add many test cases to test implicit type conversion now supported.
- Change the existing test cases
## Verifying this change
This change added tests to verify this change.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-957391630
@twalthr Thanks for driving this. I will pay more attention to the code quality of test cases. Currently, `select 1 = '1'` will generate wrong result, and all Flink (SQL) versions will be affected. About master, two solutions: 1) revert this commit, 2) or improve the test code and remove the validation code after the cast rule cover this bug. About other branches, we will not pick the cast feature to the lower versions, so just improve the test code. Improving the test case is common action, the second solution for master branch is better ? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xuyangzhong commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-954451733
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-958796993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
godfreyhe edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-962765849
ok, I will create an issue to improve the tests, FLINK-24813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "948346716",
"triggerType" : "MANUAL"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "949234522",
"triggerType" : "MANUAL"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "953957210",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d7628f9a31ac7298bee514fee7df89ff9c6e6310 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "948346716",
"triggerType" : "MANUAL"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "949234522",
"triggerType" : "MANUAL"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "953957210",
"triggerType" : "MANUAL"
}, {
"hash" : "a98d48127f8d02a4467023ebe6277eea09092ca0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25619",
"triggerID" : "954451733",
"triggerType" : "MANUAL"
}, {
"hash" : "a98d48127f8d02a4467023ebe6277eea09092ca0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25619",
"triggerID" : "a98d48127f8d02a4467023ebe6277eea09092ca0",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "954451733",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* a98d48127f8d02a4467023ebe6277eea09092ca0 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25619)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "948346716",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d7628f9a31ac7298bee514fee7df89ff9c6e6310 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "948346716",
"triggerType" : "MANUAL"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "949234522",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d7628f9a31ac7298bee514fee7df89ff9c6e6310 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-957391630
@twalthr Thanks for driving this. I will pay more attention to the code quality of test cases. Currently, `select 1 = '1'` will generate wrong result, and all Flink (SQL) versions will be affected. About master, two solutions: 1) revert this commit, 2) or improve the test code and remove the validation code after the cast rule cover this bug. About other branches, we will not pick the cast feature to the lower versions, so just improve the test code. Improving the test case is common action, the second solution for master branch is better ? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "948346716",
"triggerType" : "MANUAL"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "949234522",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d7628f9a31ac7298bee514fee7df89ff9c6e6310 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-953957210
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-956072592
@godfreyhe can you revert this PR? Let's have another discussion around it. Esp. it also mentions FLIP-154 which has neither been voted nor accepted by the Flink community yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-958770893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7837a03f2745e5d67912fda5317bf755c0a62d8f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914)
* 7892230e8d668a7f038c17b21d9fc55088f8ba89 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-956068249
@twalthr Thx for pinging! I would also vote to revert it and use the new format of `CastRulesTest` and `CastFunctionITCase` (soon to be updated with a more complete set of all supported and unsupported casts with: https://github.com/apache/flink/pull/17579) for the tests. Maybe it worths creating a new but similar class, to test implicit casting at a lower expression level, without the need to write comparison expressions for each one of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-958770893
@godfreyhe I'm also fine with the second option. The fix itself is valid. It is just the tests that need some cleanup. I think @matriv mentioned that we might extend the current cast testing infrastructure for implicits as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7837a03f2745e5d67912fda5317bf755c0a62d8f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7892230e8d668a7f038c17b21d9fc55088f8ba89 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7892230e8d668a7f038c17b21d9fc55088f8ba89 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022)
* c4bd90be195feb51f8e2535d61779d431b6d1ae4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-947481665
please use JAVA for new class @xuyangzhong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "948346716",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* c4bd90be195feb51f8e2535d61779d431b6d1ae4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051)
* d7628f9a31ac7298bee514fee7df89ff9c6e6310 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-957391630
@twalthr Thanks for driving this. I will pay more attention to the code quality of test cases. Currently, `select 1 = '1'` will generate wrong result, and all Flink (SQL) versions will be affected. About master, two solutions: 1) revert this commit, 2) or improve the test code and remove the validation code after the cast rule cover this bug. About other branches, we will not pick the cast feature to the lower versions, so just improve the test code. Improving the test case is common action, the second solution for master branch is better ? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "948346716",
"triggerType" : "MANUAL"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "949234522",
"triggerType" : "MANUAL"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "953957210",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "954451733",
"triggerType" : "MANUAL"
}, {
"hash" : "a98d48127f8d02a4467023ebe6277eea09092ca0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25619",
"triggerID" : "954451733",
"triggerType" : "MANUAL"
}, {
"hash" : "a98d48127f8d02a4467023ebe6277eea09092ca0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25619",
"triggerID" : "a98d48127f8d02a4467023ebe6277eea09092ca0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* a98d48127f8d02a4467023ebe6277eea09092ca0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25619)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4bd90be195feb51f8e2535d61779d431b6d1ae4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051)
* d7628f9a31ac7298bee514fee7df89ff9c6e6310 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xuyangzhong commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
xuyangzhong commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-948346716
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #17444:
URL: https://github.com/apache/flink/pull/17444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-962765849
ok, I will create a issue to improve the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7837a03f2745e5d67912fda5317bf755c0a62d8f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7837a03f2745e5d67912fda5317bf755c0a62d8f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914)
* 7892230e8d668a7f038c17b21d9fc55088f8ba89 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-949234522
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-958770893
@godfreyhe I'm also fine with the second option. The fix itself is valid. It is just the tests that need some cleanup. I think @matriv mentioned that we might extend the current cast testing infrastructure for implicits as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-956043981
Also, `SqlExpressionTest` adds more CAST tests. We are currently in the process in unifying the casting tests to `CastFunctionITCase` see also FLINK-24403. TBH I would vote for reverting this PR.
CC @matriv you are more involved in the casting topic, what is you opinion to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939286691
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7837a03f2745e5d67912fda5317bf755c0a62d8f (Sat Oct 09 12:08:56 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24492).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-958796993
It would be nice yes, to follow the new pattern and use it also to consolidate or implicit casting into one place, I'd fine to keep the fix and have a followup PR to restructure the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "948346716",
"triggerType" : "MANUAL"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "949234522",
"triggerType" : "MANUAL"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "953957210",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d7628f9a31ac7298bee514fee7df89ff9c6e6310 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
twalthr commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-956042111
@godfreyhe Please pay attention to the code quality. This PR adds more legacy:
```
@Rule public LegacyRowResource usesLegacyRows = LegacyRowResource.INSTANCE;
```
which could have been avoided. Also, when opening `ImplicitTypeConversionITCase` in an IDE, the file is full warnings.
`toAppendStream`, `registerTable` all of that is deprecated. `DataStreamConversions` is for implicit conversions. Not intended for Java code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7837a03f2745e5d67912fda5317bf755c0a62d8f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"triggerType" : "PUSH"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "948346716",
"triggerType" : "MANUAL"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "949234522",
"triggerType" : "MANUAL"
}, {
"hash" : "d7628f9a31ac7298bee514fee7df89ff9c6e6310",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25299",
"triggerID" : "953957210",
"triggerType" : "MANUAL"
}, {
"hash" : "a98d48127f8d02a4467023ebe6277eea09092ca0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "954451733",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "954451733",
"triggerType" : "MANUAL"
}, {
"hash" : "a98d48127f8d02a4467023ebe6277eea09092ca0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a98d48127f8d02a4467023ebe6277eea09092ca0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* a98d48127f8d02a4467023ebe6277eea09092ca0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-958796993
It would be nice yes, to follow the new pattern and use it also to consolidate or implicit casting into one place, I'd fine to keep the fix and have a followup PR to restructure the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c4bd90be195feb51f8e2535d61779d431b6d1ae4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25051)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17444:
URL: https://github.com/apache/flink/pull/17444#issuecomment-939291136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24914",
"triggerID" : "7837a03f2745e5d67912fda5317bf755c0a62d8f",
"triggerType" : "PUSH"
}, {
"hash" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022",
"triggerID" : "7892230e8d668a7f038c17b21d9fc55088f8ba89",
"triggerType" : "PUSH"
}, {
"hash" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c4bd90be195feb51f8e2535d61779d431b6d1ae4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7892230e8d668a7f038c17b21d9fc55088f8ba89 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25022)
* c4bd90be195feb51f8e2535d61779d431b6d1ae4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org