You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2013/10/28 13:00:35 UTC
[jira] [Updated] (CASSANDRA-6253) Refactor: remove CFDefinition
[ https://issues.apache.org/jira/browse/CASSANDRA-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-6253:
----------------------------------------
Attachment: 0002-Unit-tests-updates.txt
0001-Remove-CFDefinition.txt
Patch attached. This is not small because CFDefinition.Name was used a bit everywhere by the CQL3 code and since that's a refactoring ticket, I used the occasion to do a few renamings here and there, but overall this is pretty simple stuffs.
> Refactor: remove CFDefinition
> -----------------------------
>
> Key: CASSANDRA-6253
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6253
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Fix For: 2.1
>
> Attachments: 0001-Remove-CFDefinition.txt, 0002-Unit-tests-updates.txt
>
>
> While writing CQL3 initially, we added CFDefinition to be a CQL3-friendly version of CFMetaData. However, a number of changes have it redundant. The infos of CFDefinition are now in CFMetaData in pretty much the same form and in particular CFDefinition.Name is now basically a copy of ColumnDefinition. This is not only useless, but it is confusing too: sometimes the CQL3 code uses ColumnDefinition because it has too, but more often it uses CFDefinition.Name and both use diferent vocabulary even though they are the exact same thing.
> So this ticket propose to remove CFDefinition and CFDefinition.Name since they are not useful anymore and this clean things up.
--
This message was sent by Atlassian JIRA
(v6.1#6144)