[GitHub] [helix] i3wangyi commented on issue #340: Log the enqueue time of clusterEvent, used to measure the blocking qu…

[GitBox <gi...@apache.org>]

i3wangyi commented on issue #340: Log the enqueue time of clusterEvent, used to measure the blocking qu…
URL: https://github.com/apache/helix/pull/340#issuecomment-514432019
 
 
   After several thoughts on my past days' experience of investigating a production issue, I really think it is needed. 
   First, it won't overwhelm the logs since we already log every event consume at each stage. Adding the enqueue just makes the whole story complete.
   Second, the  "Controller Pipeline Queued Time" only tells you the min/max/average distribution of event processing speed. One still cannot connect the enqueue and pop steps together. One feature that could be useful is "log the enqueue event(what changes) and its reason gets queued, and compare the event consume process of the change" 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services