You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/02 07:24:46 UTC
[GitHub] [doris] mrhhsg opened a new pull request, #11434: [improvement](fe) Remove constant keys in aggregation
mrhhsg opened a new pull request, #11434:
URL: https://github.com/apache/doris/pull/11434
# Proposed changes
Issue Number: close #xxx
## Problem summary
The constant aggregation keys have no effect on the aggregation result and can be removed.
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11434: [improvement](fe) Remove constant keys in aggregation
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #11434:
URL: https://github.com/apache/doris/pull/11434#discussion_r935225782
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/AggregateInfoBase.java:
##########
@@ -95,6 +95,10 @@ protected AggregateInfoBase(AggregateInfoBase other) {
materializedSlots = Lists.newArrayList(other.materializedSlots);
}
+ public void removeConstantKeys() {
+ aggregateExprs.removeIf(expr -> expr.isConstant());
Review Comment:
👍🏻
```suggestion
groupingExprs.removeIf(Expr::isConstant);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #11434: [improvement](fe) Remove constant keys in aggregation
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11434:
URL: https://github.com/apache/doris/pull/11434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org