[GitHub] [airflow] Owen-CH-Leung commented on issue #23967: serve_logs.py should respect the logging config's task handler's base_log_folder value

["Owen-CH-Leung (via GitHub)" <gi...@apache.org>]

Owen-CH-Leung commented on issue #23967:
URL: https://github.com/apache/airflow/issues/23967#issuecomment-1646552068

   I can confirm that this issue still exists in the master branch. 
   
   My steps to reproduce in breeze: 
   1. execute `breeze start-airflow --executor CeleryExecutor --backend postgres --load-example-dags --db-reset`
   2. go to `$AIRFLOW_HOME`, create a directory called `config`, and create an empty `__init__.py` and `log_config.py` file inside
   3. Inside `airflow/config_templates/airflow_local_settings.py`, modify `DEFAULT_LOGGING_CONFIG[handlers][task][base_log_folder]` to some other different locations
   4. copy all the contents inside `airflow/config_templates/airflow_local_settings.py` into `log_config.py`
   5. In `/root/airflow/airflow.cfg` , under `logging` section,  modify `logging_config_class` to `log_config.DEFAULT_LOGGING_CONFIG`
   6. Restart everything
   7. Run a DAG in webUI, check the log, and you will see 404 not found
   
   The underlying reason is that the scheduler will ingest the `log_config.DEFAULT_LOGGING_CONFIG`, and outputs the log file to the location as specified by `base_log_folder` under `DEFAULT_LOGGING_CONFIG[handlers][task]`
   
   But the flask app still attempts to serve logs from `base_log_folder` defined under the logging section (which is `/root/airflow/logs`. Hence when flask attempts to read that folder, it returned 404.
   
   I will provide a PR to fix it soon. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org