Re: [PR] SOLR-17077: Don't cancel twice when rejoining shard leader election [solr]

["psalagnac (via GitHub)" <gi...@apache.org>]

psalagnac commented on code in PR #2084:
URL: https://github.com/apache/solr/pull/2084#discussion_r1414031688


##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/RejoinLeaderElectionPayload.java:
##########
@@ -26,13 +26,9 @@ public class RejoinLeaderElectionPayload implements ReflectMapWriter {
   // ones are meant to be required without that being specified on the v1 API or elsewhere
   @JsonProperty public String collection;
 
-  @JsonProperty public String shard;

Review Comment:
   Thanks for pointing this @dsmiley.
   I did a test locally and it seems to me any additional property in the Json payload here is simply ignored. Since this change is only removing some properties, I don't think we can have backwards-compatibility issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org