You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eumiro (via GitHub)" <gi...@apache.org> on 2023/08/08 19:19:16 UTC
[GitHub] [airflow] eumiro opened a new pull request, #33222: Refactor: Simplify code in providers/amazon
eumiro opened a new pull request, #33222:
URL: https://github.com/apache/airflow/pull/33222
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck commented on pull request #33222: Refactor: Simplify code in providers/amazon
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #33222:
URL: https://github.com/apache/airflow/pull/33222#issuecomment-1673328760
Sorry If I merged too fast folks, I did not see anything odd and everything made sense to me. I'll be more patient next time :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #33222: Refactor: Simplify code in providers/amazon
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #33222:
URL: https://github.com/apache/airflow/pull/33222#issuecomment-1673120113
> @ferruzzi I think another pass can't hurt, if you find something then we can always fix it in a follow-up PR. I'm not sure the goal of this PR, since there's no description, but there is a large surface area of code/logic changing here, something can easily slip in with those types of PRs!
I did a pass too. Could not see anything odd. FYI @o-nikolas -> this is a series of cleanups that @eumiro is apparently on a quest of - he had one huge PR to improve some of our less-than-ideal code snippets and I asked him to break it into series of smaller PRs focused on "common" areas - this one is the "aws" provider one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on pull request #33222: Refactor: Simplify code in providers/amazon
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #33222:
URL: https://github.com/apache/airflow/pull/33222#issuecomment-1672673197
> I got half way through reviewing it last night and was going to finish this afternoon. Ah well. :P Thanks for the cleanup!
@ferruzzi I think another pass can't hurt, if you find something then we can always fix it in a follow-up PR. I'm not sure the goal of this PR, since there's no description, but there is a large surface area of code/logic changing here, something can easily slip in with those types of PRs!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck merged pull request #33222: Refactor: Simplify code in providers/amazon
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #33222:
URL: https://github.com/apache/airflow/pull/33222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on pull request #33222: Refactor: Simplify code in providers/amazon
Posted by "ferruzzi (via GitHub)" <gi...@apache.org>.
ferruzzi commented on PR #33222:
URL: https://github.com/apache/airflow/pull/33222#issuecomment-1671897274
I got half way through reviewing it last night and was going to finish this afternoon. Ah well. :P Thanks for the cleanup!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org