You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Zouxxyy (via GitHub)" <gi...@apache.org> on 2024/01/18 02:23:00 UTC

[PR] [MINOR] Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test [hudi]

Zouxxyy opened a new pull request, #10526:
URL: https://github.com/apache/hudi/pull/10526

   ### Change Logs
   
   _Describe context and summary for this change. Highlight if any code was copied._
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10526:
URL: https://github.com/apache/hudi/pull/10526#issuecomment-1897699724

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2a0209db41eb4247ed1447ab2907709a5d173719",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2a0209db41eb4247ed1447ab2907709a5d173719",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2a0209db41eb4247ed1447ab2907709a5d173719 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test [hudi]

Posted by "KnightChess (via GitHub)" <gi...@apache.org>.
KnightChess commented on code in PR #10526:
URL: https://github.com/apache/hudi/pull/10526#discussion_r1460890602


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java:
##########
@@ -531,34 +531,35 @@ public void testMultiWriterWithAsyncTableServicesWithConflict(HoodieTableType ta
 
         // Since the concurrent modifications went in, this upsert has
         // to fail
+        // Note: the start time of upsert must be smaller than the compaction scheduling time

Review Comment:
   hi, why this upsert commit must be smaller than compaction scheduling time, can you describe the problem in detail.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10526:
URL: https://github.com/apache/hudi/pull/10526#issuecomment-1897803589

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2a0209db41eb4247ed1447ab2907709a5d173719",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22027",
       "triggerID" : "2a0209db41eb4247ed1447ab2907709a5d173719",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2a0209db41eb4247ed1447ab2907709a5d173719 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22027) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test [hudi]

Posted by "voonhous (via GitHub) via commits" <co...@hudi.apache.org>.
voonhous commented on PR #10526:
URL: https://github.com/apache/hudi/pull/10526#issuecomment-6700282106

   Temporarily closing this PR while we debug a GitHub settings error on master (#20471); it will be reopened shortly, no action needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test [hudi]

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #10526:
URL: https://github.com/apache/hudi/pull/10526#issuecomment-2185362932

   This fix is related to [HUDI-7483](https://issues.apache.org/jira/browse/HUDI-7483).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test [hudi]

Posted by "voonhous (via GitHub) via commits" <co...@hudi.apache.org>.
voonhous closed pull request #10526: [MINOR] Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test
URL: https://github.com/apache/hudi/pull/10526


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test [hudi]

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #10526:
URL: https://github.com/apache/hudi/pull/10526#issuecomment-1989887645

   Hi, @Zouxxyy , can you clarify the review comments and we are good to land.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MINOR] Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10526:
URL: https://github.com/apache/hudi/pull/10526#issuecomment-1897705857

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2a0209db41eb4247ed1447ab2907709a5d173719",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22027",
       "triggerID" : "2a0209db41eb4247ed1447ab2907709a5d173719",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2a0209db41eb4247ed1447ab2907709a5d173719 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=22027) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org