You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/03/07 19:04:29 UTC

Re: Review Request 43856: GEODE-997: Update Pulse build to reduce bundled jars

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43856/#review122317
-----------------------------------------------------------


Ship it!




Ship It!

- Jinmei Liao


On Feb. 23, 2016, 12:11 a.m., Jens Deppe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43856/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 12:11 a.m.)
> 
> 
> Review request for geode, Anthony Baker, Jinmei Liao, and Kirk Lund.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-997: Update Pulse build to reduce bundled jars
> 
> This review is related to the story to ensure that all Pulse dependencies are reflected in the NOTICE and LICENSE files. From that POV I believe we are good and have all our 3rd party libs covered.
> 
> While checking artifacts, etc. I noticed that some jars were duplicated in the war and some are not required by Pulse (specifically jars related to findbugs and cdi-api). This review address that.
> 
> 
> Diffs
> -----
> 
>   geode-pulse/build.gradle ebd851a70ccccfea6448f1efc6207c5e0a83ec61 
> 
> Diff: https://reviews.apache.org/r/43856/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jens Deppe
> 
>