You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Dave Watson (JIRA)" <ji...@apache.org> on 2011/06/29 00:09:28 UTC
[jira] [Created] (THRIFT-1225) TCompactProtocol for PHP
TCompactProtocol for PHP
------------------------
Key: THRIFT-1225
URL: https://issues.apache.org/jira/browse/THRIFT-1225
Project: Thrift
Issue Type: Improvement
Components: PHP - Library
Affects Versions: 0.7
Reporter: Dave Watson
A TCompactProtocol implementation for PHP. Similar to the Python version.
Except the I64 stuff. I64 doesn't work on 32bit PHP, it uses two 32bit ints instead and a bunch of bit fiddling.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1225) TCompactProtocol for PHP
Posted by "Dave Watson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Watson updated THRIFT-1225:
--------------------------------
Attachment: thrift-1225.patch
> TCompactProtocol for PHP
> ------------------------
>
> Key: THRIFT-1225
> URL: https://issues.apache.org/jira/browse/THRIFT-1225
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.7
> Reporter: Dave Watson
> Attachments: thrift-1225.patch
>
>
> A TCompactProtocol implementation for PHP. Similar to the Python version.
> Except the I64 stuff. I64 doesn't work on 32bit PHP, it uses two 32bit ints instead and a bunch of bit fiddling.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1225) TCompactProtocol for PHP
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064764#comment-13064764 ]
Hudson commented on THRIFT-1225:
--------------------------------
Integrated in Thrift #192 (See [https://builds.apache.org/job/Thrift/192/])
THRIFT-1225. php: TCompactProtocol for PHP
Patch: Dave Watson
bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1146185
Files :
* /thrift/trunk/lib/php/src/protocol/TCompactProtocol.php
> TCompactProtocol for PHP
> ------------------------
>
> Key: THRIFT-1225
> URL: https://issues.apache.org/jira/browse/THRIFT-1225
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.7
> Reporter: Dave Watson
> Assignee: Dave Watson
> Fix For: 0.7
>
> Attachments: thrift-1225.patch
>
>
> A TCompactProtocol implementation for PHP. Similar to the Python version.
> Except the I64 stuff. I64 doesn't work on 32bit PHP, it uses two 32bit ints instead and a bunch of bit fiddling.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1225) TCompactProtocol for PHP
Posted by "Dave Watson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064750#comment-13064750 ]
Dave Watson commented on THRIFT-1225:
-------------------------------------
Yea at FB our php code lives in a different directory structure, and I added unit tests there. I should update the TestServer/TestClient to accept TCompact though.
Thanks!
> TCompactProtocol for PHP
> ------------------------
>
> Key: THRIFT-1225
> URL: https://issues.apache.org/jira/browse/THRIFT-1225
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.7
> Reporter: Dave Watson
> Assignee: Dave Watson
> Fix For: 0.7
>
> Attachments: thrift-1225.patch
>
>
> A TCompactProtocol implementation for PHP. Similar to the Python version.
> Except the I64 stuff. I64 doesn't work on 32bit PHP, it uses two 32bit ints instead and a bunch of bit fiddling.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1225) TCompactProtocol for PHP
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1225.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.7
Assignee: Dave Watson
I did a very cursory review and this looks faithful. I'd really like to have tests, but we can do those later, I guess. I committed the patch. Thanks Dave!
> TCompactProtocol for PHP
> ------------------------
>
> Key: THRIFT-1225
> URL: https://issues.apache.org/jira/browse/THRIFT-1225
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.7
> Reporter: Dave Watson
> Assignee: Dave Watson
> Fix For: 0.7
>
> Attachments: thrift-1225.patch
>
>
> A TCompactProtocol implementation for PHP. Similar to the Python version.
> Except the I64 stuff. I64 doesn't work on 32bit PHP, it uses two 32bit ints instead and a bunch of bit fiddling.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira