[GitHub] [geode] kirklund commented on a change in pull request #6924: GEODE-9645: Don't notify servers of new DataSerializers

[GitBox <gi...@apache.org>]

kirklund commented on a change in pull request #6924:
URL: https://github.com/apache/geode/pull/6924#discussion_r720421746



##########
File path: geode-core/src/main/java/org/apache/geode/cache/client/internal/EndpointManagerImpl.java
##########
@@ -181,6 +182,11 @@ public void removeListener(EndpointManager.EndpointListener listener) {
     this.listener.removeListener(listener);
   }
 
+  @TestOnly

Review comment:
       Do we have guidelines on when to use `@TestOnly` versus `@VisibleForTesting`?

##########
File path: geode-core/src/test/java/org/apache/geode/internal/cache/PoolManagerTest.java
##########
@@ -37,6 +65,112 @@ public void setUp() {
     assertThat(poolManager.getMap()).isEmpty();
   }
 
+  // in Mulituser Auth mode
+  @Test
+  public void Test_thatDataSerializerSynchronizationMessagesAreNotSent() {

Review comment:
       You should use camel case. The method names should start with lowercase unless there's some unusual reason why it helps with organization and understanding of a class.

##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/PoolManagerImpl.java
##########
@@ -63,6 +64,11 @@ public static PoolManagerImpl getPMI() {
     return result;
   }
 
+  @TestOnly
+  public static void setImpl(PoolManagerImpl poolManager) {
+    impl = poolManager;
+  }
+

Review comment:
       I think we're going in the wrong direction with some of these TestOnly setters, especially when the constant or variable is annotated with `@MakeNotStatic` and it needs to have `final` removed to make it work.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org