You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/17 20:59:43 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #12846: [Broker] Fix producer getting incorrectly removed from topic's produc…

merlimat commented on a change in pull request #12846:
URL: https://github.com/apache/pulsar/pull/12846#discussion_r751631773



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Producer.java
##########
@@ -147,22 +147,17 @@ private String parseRemoteClusterName(String producerName, boolean isRemote) {
         return null;
     }
 
-    @Override

Review comment:
       Should we leave `hashCode()` & `equals()` with explanation on why it needs to be identity equal? Otherwise, someone will add it back later on... 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org