You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2014/09/20 03:19:34 UTC
Review Request 25870: Use AssistedInject to allow guice to construct
StreamManager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Repository: aurora
Description
-------
Use Guice AssistedInject to construct StreamManager
Refactor other component in log to be Guice-constructed.
More info: https://github.com/google/guice/wiki/AssistedInject
Diffs
-----
build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883
src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064
src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa
Diff: https://reviews.apache.org/r/25870/diff/
Testing
-------
./gradlew -Pq build
Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars)
Thanks,
Kevin Sweeney
Re: Review Request 25870: Use AssistedInject to allow guice to
construct StreamManager
Posted by Kevin Sweeney <ke...@apache.org>.
> On Sept. 22, 2014, 11 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java, line 127
> > <https://reviews.apache.org/r/25870/diff/1/?file=698533#file698533line127>
> >
> > What's the context around replacing MessageDigest with HashFunction? Is it perf gain? Any details on how better it is?
It delegates to the same underlying code, it's just the Guava interface for it (type-safe construction, immutable function object).
See http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/hash/Hashing.html#md5()
> On Sept. 22, 2014, 11 a.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java, lines 86-87
> > <https://reviews.apache.org/r/25870/diff/1/?file=698533#file698533line86>
> >
> > Static imports?
Done.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/#review54150
-----------------------------------------------------------
On Sept. 22, 2014, 11:52 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25870/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 11:52 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use Guice AssistedInject to construct StreamManager
> Refactor other component in log to be Guice-constructed.
>
> More info: https://github.com/google/guice/wiki/AssistedInject
>
>
> Diffs
> -----
>
> build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883
> src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064
> src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa
>
> Diff: https://reviews.apache.org/r/25870/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
> Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars)
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 25870: Use AssistedInject to allow guice to
construct StreamManager
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/#review54150
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java
<https://reviews.apache.org/r/25870/#comment94145>
Static imports?
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java
<https://reviews.apache.org/r/25870/#comment94146>
What's the context around replacing MessageDigest with HashFunction? Is it perf gain? Any details on how better it is?
- Maxim Khutornenko
On Sept. 20, 2014, 1:19 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25870/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2014, 1:19 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use Guice AssistedInject to construct StreamManager
> Refactor other component in log to be Guice-constructed.
>
> More info: https://github.com/google/guice/wiki/AssistedInject
>
>
> Diffs
> -----
>
> build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883
> src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064
> src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa
>
> Diff: https://reviews.apache.org/r/25870/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
> Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars)
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 25870: Use AssistedInject to allow guice to
construct StreamManager
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/#review54214
-----------------------------------------------------------
Ping wfarner
- Kevin Sweeney
On Sept. 22, 2014, 4:07 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25870/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 4:07 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use Guice AssistedInject to construct StreamManager
> Refactor other component in log to be Guice-constructed.
>
> More info: https://github.com/google/guice/wiki/AssistedInject
>
>
> Diffs
> -----
>
> build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883
> src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064
> src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa
>
> Diff: https://reviews.apache.org/r/25870/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
> Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars)
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 25870: Use AssistedInject to allow guice to
construct StreamManager
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/
-----------------------------------------------------------
(Updated Sept. 22, 2014, 6:39 p.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Changes
-------
rebase
Repository: aurora
Description
-------
Use Guice AssistedInject to construct StreamManager
Refactor other components in log to be Guice-constructed.
More info: https://github.com/google/guice/wiki/AssistedInject
Diffs (updated)
-----
build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883
src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 156cc80440a0d4bf97c056adcd6afc5e9ab1fb83
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 06e2e8d47d063d1e0afe86f9d4f164b727b15a73
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064
src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa
Diff: https://reviews.apache.org/r/25870/diff/
Testing
-------
./gradlew -Pq build
Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars)
Thanks,
Kevin Sweeney
Re: Review Request 25870: Use AssistedInject to allow guice to
construct StreamManager
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/
-----------------------------------------------------------
(Updated Sept. 22, 2014, 6:35 p.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Changes
-------
Bill's feedback.
Repository: aurora
Description (updated)
-------
Use Guice AssistedInject to construct StreamManager
Refactor other components in log to be Guice-constructed.
More info: https://github.com/google/guice/wiki/AssistedInject
Diffs (updated)
-----
build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883
src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064
src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa
Diff: https://reviews.apache.org/r/25870/diff/
Testing
-------
./gradlew -Pq build
Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars)
Thanks,
Kevin Sweeney
Re: Review Request 25870: Use AssistedInject to allow guice to
construct StreamManager
Posted by Kevin Sweeney <ke...@apache.org>.
> On Sept. 22, 2014, 6:12 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java, line 63
> > <https://reviews.apache.org/r/25870/diff/3/?file=700622#file700622line63>
> >
> > While you're here, might as well drop @Timed to start collecting data on this.
Done.
> On Sept. 22, 2014, 6:12 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java, line 98
> > <https://reviews.apache.org/r/25870/diff/3/?file=700625#file700625line98>
> >
> > Comment implies this is a known problem. How about:
> > "Assess performance of md5 versus other hash functions."
Updated TODO with justification.
> On Sept. 22, 2014, 6:12 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java, line 33
> > <https://reviews.apache.org/r/25870/diff/3/?file=700626#file700626line33>
> >
> > s/public //
Done - automated refactoring got a little out of hand raising visibility.
> On Sept. 22, 2014, 6:12 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java, line 62
> > <https://reviews.apache.org/r/25870/diff/3/?file=700628#file700628line62>
> >
> > s/public //? i can't find any uses outside the package
Fixed.
> On Sept. 22, 2014, 6:12 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java, line 24
> > <https://reviews.apache.org/r/25870/diff/3/?file=700629#file700629line24>
> >
> > s/public //
Fixed.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/#review54224
-----------------------------------------------------------
On Sept. 22, 2014, 6:35 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25870/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 6:35 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use Guice AssistedInject to construct StreamManager
> Refactor other components in log to be Guice-constructed.
>
> More info: https://github.com/google/guice/wiki/AssistedInject
>
>
> Diffs
> -----
>
> build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883
> src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064
> src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa
>
> Diff: https://reviews.apache.org/r/25870/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
> Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars)
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 25870: Use AssistedInject to allow guice to
construct StreamManager
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/#review54224
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java
<https://reviews.apache.org/r/25870/#comment94230>
While you're here, might as well drop @Timed to start collecting data on this.
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java
<https://reviews.apache.org/r/25870/#comment94232>
Comment implies this is a known problem. How about:
"Assess performance of md5 versus other hash functions."
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java
<https://reviews.apache.org/r/25870/#comment94236>
s/public //
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java
<https://reviews.apache.org/r/25870/#comment94234>
s/public //? i can't find any uses outside the package
src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java
<https://reviews.apache.org/r/25870/#comment94235>
s/public //
- Bill Farner
On Sept. 22, 2014, 11:07 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25870/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 11:07 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use Guice AssistedInject to construct StreamManager
> Refactor other component in log to be Guice-constructed.
>
> More info: https://github.com/google/guice/wiki/AssistedInject
>
>
> Diffs
> -----
>
> build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883
> src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064
> src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa
>
> Diff: https://reviews.apache.org/r/25870/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
> Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars)
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 25870: Use AssistedInject to allow guice to
construct StreamManager
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/
-----------------------------------------------------------
(Updated Sept. 22, 2014, 4:07 p.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Changes
-------
Use interface instead of impl as return type
Repository: aurora
Description
-------
Use Guice AssistedInject to construct StreamManager
Refactor other component in log to be Guice-constructed.
More info: https://github.com/google/guice/wiki/AssistedInject
Diffs (updated)
-----
build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883
src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064
src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa
Diff: https://reviews.apache.org/r/25870/diff/
Testing
-------
./gradlew -Pq build
Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars)
Thanks,
Kevin Sweeney
Re: Review Request 25870: Use AssistedInject to allow guice to
construct StreamManager
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/#review54171
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 22, 2014, 6:52 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25870/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 6:52 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use Guice AssistedInject to construct StreamManager
> Refactor other component in log to be Guice-constructed.
>
> More info: https://github.com/google/guice/wiki/AssistedInject
>
>
> Diffs
> -----
>
> build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883
> src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064
> src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa
>
> Diff: https://reviews.apache.org/r/25870/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
> Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars)
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 25870: Use AssistedInject to allow guice to
construct StreamManager
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25870/
-----------------------------------------------------------
(Updated Sept. 22, 2014, 11:52 a.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Changes
-------
Maxim's feedback
Repository: aurora
Description
-------
Use Guice AssistedInject to construct StreamManager
Refactor other component in log to be Guice-constructed.
More info: https://github.com/google/guice/wiki/AssistedInject
Diffs (updated)
-----
build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883
src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064
src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa
Diff: https://reviews.apache.org/r/25870/diff/
Testing
-------
./gradlew -Pq build
Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars)
Thanks,
Kevin Sweeney