You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by PivotalSarge <gi...@git.apache.org> on 2017/02/22 16:50:59 UTC
[GitHub] geode-native pull request #23: GEODE-2478: Replace gf with geode.
GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/23
GEODE-2478: Replace gf with geode.
- Rename directories and files with gf into their name to
instead use geode and update all references thereto.
- Ensure formatting style guide compliance.
- Elide duplicate GEODE_ from include guards.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PivotalSarge/geode-native feature/GEODE-2478
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode-native/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit a58b1440b76a3d693e720ce72b6cd18a26fbc8c0
Author: Sarge <md...@pivotal.io>
Date: 2017-02-22T03:41:10Z
GEODE-2478: Replace gf with geode.
- Rename directories and files with gf into their name to
instead use geode and update all references thereto.
- Ensure formatting style guide compliance.
- Elide duplicate GEODE_ from include guards.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native issue #23: GEODE-2478: Replace gf with geode.
Posted by PivotalSarge <gi...@git.apache.org>.
Github user PivotalSarge commented on the issue:
https://github.com/apache/geode-native/pull/23
Good idea. I think you're right about redundancies. I'll look into that.
Sarge
> On 22 Feb, 2017, at 10:48, Jacob Barrett <no...@github.com> wrote:
>
> @pivotal-jbarrett approved this pull request.
>
> I would suggest opening a ticket with any cleanup ideas you may have seen when going through all these headers. Seems like geode_defs and geode_base and and whatever generically named includes we have might be fairly redundant and ripe for cleanup or reorganization.
>
> Otherwise this looks good.
>
> \u2014
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <https://github.com/apache/geode-native/pull/23#pullrequestreview-23299880>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATlz4uDEUOa4K1RgRpgEMG-urzHriHQGks5rfILmgaJpZM4MI5mz>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #23: GEODE-2478: Replace gf with geode.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode-native/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---