[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41685: [SPARK-43876][SQL][FOLLOWUP] Enable fast hashmap for distinct queries

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #41685:
URL: https://github.com/apache/spark/pull/41685#discussion_r1236258297


##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala:
##########
@@ -1987,6 +1987,16 @@ class DataFrameAggregateSuite extends QueryTest
     }
     assert(error7.toString contains "UnsupportedOperationException")
   }
+
+  test("SPARK-43876: Enable fast hashmap for distinct queries") {
+    val df = testData2.distinct()
+    checkAnswer(df, testData2)
+    val output = new java.io.ByteArrayOutputStream()
+    Console.withOut(output) {
+      df.explain("codegen")
+    }
+    assert(output.toString().contains("public class hashAgg_FastHashMap_0"))

Review Comment:
   Nice!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org