You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/20 17:24:49 UTC
[GitHub] [incubator-nuttx] acassis opened a new pull request #3954: stm32f103-minimum/sensors: Remove DS28E17 that is not used and add SENSORTEST
acassis opened a new pull request #3954:
URL: https://github.com/apache/incubator-nuttx/pull/3954
## Summary
Remove DS28E17 that is not used and add SENSORTEST
## Impact
Only for BluePill board
## Testing
BluePill
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ocramlhark commented on pull request #3954: stm32f103-minimum/sensors: Remove DS28E17 that is not used and add SENSORTEST
Posted by GitBox <gi...@apache.org>.
ocramlhark commented on pull request #3954:
URL: https://github.com/apache/incubator-nuttx/pull/3954#issuecomment-864596501
Hi Alan,
yes I will do that tomorrow.
On Sun, Jun 20, 2021, 19:26 Alan Carvalho de Assis ***@***.***>
wrote:
> Please @ocramlhark <https://github.com/ocramlhark> review it.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-nuttx/pull/3954#issuecomment-864586541>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ATOMAXCYIFJ775U2NTQLBZDTTYQGFANCNFSM47AIE5TA>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3954: stm32f103-minimum/sensors: Remove DS28E17 that is not used and add SENSORTEST
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3954:
URL: https://github.com/apache/incubator-nuttx/pull/3954#issuecomment-864586541
Please @ocramlhark review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ocramlhark edited a comment on pull request #3954: stm32f103-minimum/sensors: Remove DS28E17 that is not used and add SENSORTEST
Posted by GitBox <gi...@apache.org>.
ocramlhark edited a comment on pull request #3954:
URL: https://github.com/apache/incubator-nuttx/pull/3954#issuecomment-864596501
Hi Alan,
yes I will do that tomorrow.
On Sun, Jun 20, 2021, 19:26 Alan Carvalho de Assis ***@***.***>
wrote:
> Please @ocramlhark <https://github.com/ocramlhark> review it.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-nuttx/pull/3954#issuecomment-864586541>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ATOMAXCYIFJ775U2NTQLBZDTTYQGFANCNFSM47AIE5TA>
> .
>
Oh, I'm too late, but your patch is fine. This was an obsolete artifact that comes from the old configuration based on 1-wire implementation from Juha.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ocramlhark edited a comment on pull request #3954: stm32f103-minimum/sensors: Remove DS28E17 that is not used and add SENSORTEST
Posted by GitBox <gi...@apache.org>.
ocramlhark edited a comment on pull request #3954:
URL: https://github.com/apache/incubator-nuttx/pull/3954#issuecomment-864596501
Hi Alan,
yes I will do that tomorrow.
On Sun, Jun 20, 2021, 19:26 Alan Carvalho de Assis ***@***.***>
wrote:
> Please @ocramlhark <https://github.com/ocramlhark> review it.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-nuttx/pull/3954#issuecomment-864586541>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ATOMAXCYIFJ775U2NTQLBZDTTYQGFANCNFSM47AIE5TA>
> .
>
Oh, I'm too late, but your patch is fine. This was an obsolete artifact that comes from the old configuration based on 1-wire implementation from Juha.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3954: stm32f103-minimum/sensors: Remove DS28E17 that is not used and add SENSORTEST
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3954:
URL: https://github.com/apache/incubator-nuttx/pull/3954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org