You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/08 07:56:29 UTC
[GitHub] [flink] XComp opened a new pull request #14584: [FLINK-20580][runtime] Removing usage of CoLocationConstraints
XComp opened a new pull request #14584:
URL: https://github.com/apache/flink/pull/14584
## What is the purpose of the change
The `CoLocationConstraint` class became obsolete when introducing [FLINK-18690](https://issues.apache.org/jira/browse/FLINK-18689).
This PR depends on PR #14580 covering [FLINK-20892](https://issues.apache.org/jira/browse/FLINK-20892).
## Brief change log
* The `CoLocationConstraint` was removed from the code clearing any existing member fields and updating/removing related test cases.
## Verifying this change
CI Build
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14584: [FLINK-20580][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756609457
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-758016269
> @XComp how about we get the base PRs merged before continuing with this PR? I can see that all the base PRs are approved already.
Ok, @rmetzger merged the previous PR. I rebased `master`...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac41760be08390054d51f810056735bb72951d6a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
}, {
"hash" : "bbabee468dc4cea40929884682260ca046e63b48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855",
"triggerID" : "bbabee468dc4cea40929884682260ca046e63b48",
"triggerType" : "PUSH"
}, {
"hash" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11869",
"triggerID" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"triggerType" : "PUSH"
}, {
"hash" : "7dea123463f8110e4bff843854c2fc66bc24a7ff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7dea123463f8110e4bff843854c2fc66bc24a7ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11869)
* 7dea123463f8110e4bff843854c2fc66bc24a7ff UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a10a1feecffd930d01e57997abd2db59d4aae762 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
}, {
"hash" : "bbabee468dc4cea40929884682260ca046e63b48",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855",
"triggerID" : "bbabee468dc4cea40929884682260ca046e63b48",
"triggerType" : "PUSH"
}, {
"hash" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11869",
"triggerID" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bbabee468dc4cea40929884682260ca046e63b48 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855)
* daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11869)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
}, {
"hash" : "bbabee468dc4cea40929884682260ca046e63b48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855",
"triggerID" : "bbabee468dc4cea40929884682260ca046e63b48",
"triggerType" : "PUSH"
}, {
"hash" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11869",
"triggerID" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11869)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7221719360b731dbf1711be4968af87d8f0900b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805)
* 4393af4fff1792cefbc7d9489e137bd4b0387457 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac41760be08390054d51f810056735bb72951d6a Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787)
* a10a1feecffd930d01e57997abd2db59d4aae762 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger closed pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #14584:
URL: https://github.com/apache/flink/pull/14584
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
XComp edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-758016269
> @XComp how about we get the base PRs merged before continuing with this PR? I can see that all the base PRs are approved already.
Ok, @rmetzger merged the previous PRs. I rebased `master`...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-757761683
@XComp how about we get the base PRs merged before continuing with this PR? I can see that all the base PRs are approved already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
}, {
"hash" : "bbabee468dc4cea40929884682260ca046e63b48",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855",
"triggerID" : "bbabee468dc4cea40929884682260ca046e63b48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4393af4fff1792cefbc7d9489e137bd4b0387457 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823)
* bbabee468dc4cea40929884682260ca046e63b48 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
}, {
"hash" : "bbabee468dc4cea40929884682260ca046e63b48",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855",
"triggerID" : "bbabee468dc4cea40929884682260ca046e63b48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bbabee468dc4cea40929884682260ca046e63b48 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14584:
URL: https://github.com/apache/flink/pull/14584#discussion_r556424337
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java
##########
@@ -425,12 +426,12 @@ public void setStrictlyCoLocatedWith(JobVertex strictlyCoLocatedWith) {
"Strict co-location requires that both vertices are in the same slot sharing group.");
}
- CoLocationGroup thisGroup = this.coLocationGroup;
- CoLocationGroup otherGroup = strictlyCoLocatedWith.coLocationGroup;
+ CoLocationGroupImpl thisGroup = this.coLocationGroup;
+ CoLocationGroupImpl otherGroup = strictlyCoLocatedWith.coLocationGroup;
Review comment:
I see, this is only the initialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756609457
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 51e43557612c34ce0e2803014fa8a00c789ed158 (Fri May 28 07:06:42 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #14584:
URL: https://github.com/apache/flink/pull/14584#discussion_r556320209
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -1018,10 +1018,10 @@ private void setCoLocation() {
"Cannot use a co-location constraint without a slot sharing group");
}
- Tuple2<SlotSharingGroup, CoLocationGroup> constraint =
+ Tuple2<SlotSharingGroup, CoLocationGroupImpl> constraint =
coLocationGroups.computeIfAbsent(
coLocationGroupKey,
- k -> new Tuple2<>(sharingGroup, new CoLocationGroup()));
+ k -> new Tuple2<>(sharingGroup, new CoLocationGroupImpl()));
Review comment:
See my answer above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a10a1feecffd930d01e57997abd2db59d4aae762 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796)
* 96bfc4315368e6c105b5a55af9eeff2268990861 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 96bfc4315368e6c105b5a55af9eeff2268990861 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800)
* a7221719360b731dbf1711be4968af87d8f0900b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14584: [FLINK-20580][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756609457
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit ac41760be08390054d51f810056735bb72951d6a (Fri Jan 08 07:58:02 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20580).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
}, {
"hash" : "bbabee468dc4cea40929884682260ca046e63b48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855",
"triggerID" : "bbabee468dc4cea40929884682260ca046e63b48",
"triggerType" : "PUSH"
}, {
"hash" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11869",
"triggerID" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"triggerType" : "PUSH"
}, {
"hash" : "7dea123463f8110e4bff843854c2fc66bc24a7ff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11888",
"triggerID" : "7dea123463f8110e4bff843854c2fc66bc24a7ff",
"triggerType" : "PUSH"
}, {
"hash" : "51e43557612c34ce0e2803014fa8a00c789ed158",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11905",
"triggerID" : "51e43557612c34ce0e2803014fa8a00c789ed158",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51e43557612c34ce0e2803014fa8a00c789ed158 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14584: [FLINK-20580][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac41760be08390054d51f810056735bb72951d6a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
XComp commented on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-757673753
The refactoring is ready to be reviewed. Please also have a look at the docs changes that were necessary due to the refactoring.
@zhuzhurk It would be helpful for you to have a look as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #14584:
URL: https://github.com/apache/flink/pull/14584#discussion_r556320074
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java
##########
@@ -425,12 +426,12 @@ public void setStrictlyCoLocatedWith(JobVertex strictlyCoLocatedWith) {
"Strict co-location requires that both vertices are in the same slot sharing group.");
}
- CoLocationGroup thisGroup = this.coLocationGroup;
- CoLocationGroup otherGroup = strictlyCoLocatedWith.coLocationGroup;
+ CoLocationGroupImpl thisGroup = this.coLocationGroup;
+ CoLocationGroupImpl otherGroup = strictlyCoLocatedWith.coLocationGroup;
Review comment:
The idea was to have a readonly interface as the colocation groups do not need to be changed after initialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7221719360b731dbf1711be4968af87d8f0900b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805)
* 4393af4fff1792cefbc7d9489e137bd4b0387457 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #14584:
URL: https://github.com/apache/flink/pull/14584#discussion_r555142323
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java
##########
@@ -331,15 +331,11 @@ public int getNumberOfVertices() {
return Collections.unmodifiableSet(slotSharingGroups);
}
- public Set<CoLocationGroupDesc> getCoLocationGroupDescriptors() {
- // invoke distinct() on CoLocationGroup first to avoid creating
- // multiple CoLocationGroupDec from one CoLocationGroup
- final Set<CoLocationGroupDesc> coLocationGroups =
+ public Set<CoLocationGroup> getCoLocationGroup() {
Review comment:
`getCoLocationGroups` would be better
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/JobGraphTest.java
##########
@@ -426,7 +426,7 @@ public void testGetSlotSharingGroups() {
}
@Test
- public void testGetCoLocationGroupDescriptors() {
+ public void testGetCoLocationGroup() {
Review comment:
maybe `testGetCoLocationGroups`?
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/CoLocationGroup.java
##########
@@ -19,105 +19,41 @@
package org.apache.flink.runtime.jobmanager.scheduler;
import org.apache.flink.runtime.jobgraph.JobVertex;
+import org.apache.flink.runtime.jobgraph.JobVertexID;
import org.apache.flink.util.AbstractID;
-import org.apache.flink.util.Preconditions;
-import java.util.ArrayList;
import java.util.List;
/**
- * A Co-location group is a group of JobVertices, where the <i>i-th</i> subtask of one vertex has to
- * be executed on the same TaskManager as the <i>i-th</i> subtask of all other JobVertices in the
- * same group.
+ * {@code CoLocationGroup} refers to a list of {@link JobVertex} instances, where the <i>i-th</i>
+ * subtask of one vertex has to be executed on the same {@code TaskManager} as the <i>i-th</i>
+ * subtask of all other {@code JobVertex} instances in the same group.
*
- * <p>The co-location group is used for example to make sure that the i-th subtasks for iteration
- * head and iteration tail are scheduled to the same TaskManager.
+ * <p>The co-location group is used to make sure that the i-th subtasks for iteration head and
+ * iteration tail are scheduled on the same TaskManager.
*/
-public class CoLocationGroup implements java.io.Serializable {
+public interface CoLocationGroup {
- private static final long serialVersionUID = -2605819490401895297L;
-
- /** The ID that describes the slot co-location-constraint as a group */
- private final AbstractID id = new AbstractID();
-
- /** The vertices participating in the co-location group */
- private final List<JobVertex> vertices = new ArrayList<JobVertex>();
-
- /** The constraints, which hold the shared slots for the co-located operators */
- private transient ArrayList<CoLocationConstraint> constraints;
-
- // --------------------------------------------------------------------------------------------
-
- public CoLocationGroup() {}
-
- public CoLocationGroup(JobVertex... vertices) {
- for (JobVertex v : vertices) {
- this.vertices.add(v);
- }
- }
-
- // --------------------------------------------------------------------------------------------
-
- public void addVertex(JobVertex vertex) {
- Preconditions.checkNotNull(vertex);
- this.vertices.add(vertex);
- }
-
- public List<JobVertex> getVertices() {
- return vertices;
- }
-
- public void mergeInto(CoLocationGroup other) {
- Preconditions.checkNotNull(other);
-
- for (JobVertex v : this.vertices) {
- v.updateCoLocationGroup(other);
- }
-
- // move vertex membership
- other.vertices.addAll(this.vertices);
- this.vertices.clear();
- }
-
- // --------------------------------------------------------------------------------------------
-
- public CoLocationConstraint getLocationConstraint(int subtask) {
- ensureConstraints(subtask + 1);
- return constraints.get(subtask);
- }
-
- private void ensureConstraints(int num) {
- if (constraints == null) {
- constraints = new ArrayList<CoLocationConstraint>(num);
- } else {
- constraints.ensureCapacity(num);
- }
-
- if (num > constraints.size()) {
- constraints.ensureCapacity(num);
- for (int i = constraints.size(); i < num; i++) {
- constraints.add(new CoLocationConstraint(this));
- }
- }
- }
+ /**
+ * Returns the unique identifier describing this co-location constraint as a group.
+ *
+ * @return The group's identifier.
+ */
+ AbstractID getId();
/**
- * Gets the ID that identifies this co-location group.
+ * Returns the IDs of the {@link JobVertex} instances participating in this group.
*
- * @return The ID that identifies this co-location group.
+ * @return The group's members represented by their {@link JobVertexID}s.
*/
- public AbstractID getId() {
- return id;
- }
+ List<JobVertexID> getVertexIDs();
Review comment:
NIT: `getVertexIds()` would be better towards a common naming pattern. There exists some `getXXXID()` but I think the latest new names are always `getXXXId()`/`getXXXIds()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
}, {
"hash" : "bbabee468dc4cea40929884682260ca046e63b48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855",
"triggerID" : "bbabee468dc4cea40929884682260ca046e63b48",
"triggerType" : "PUSH"
}, {
"hash" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11869",
"triggerID" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"triggerType" : "PUSH"
}, {
"hash" : "7dea123463f8110e4bff843854c2fc66bc24a7ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11888",
"triggerID" : "7dea123463f8110e4bff843854c2fc66bc24a7ff",
"triggerType" : "PUSH"
}, {
"hash" : "51e43557612c34ce0e2803014fa8a00c789ed158",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "51e43557612c34ce0e2803014fa8a00c789ed158",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dea123463f8110e4bff843854c2fc66bc24a7ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11888)
* 51e43557612c34ce0e2803014fa8a00c789ed158 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
}, {
"hash" : "bbabee468dc4cea40929884682260ca046e63b48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855",
"triggerID" : "bbabee468dc4cea40929884682260ca046e63b48",
"triggerType" : "PUSH"
}, {
"hash" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11869",
"triggerID" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"triggerType" : "PUSH"
}, {
"hash" : "7dea123463f8110e4bff843854c2fc66bc24a7ff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11888",
"triggerID" : "7dea123463f8110e4bff843854c2fc66bc24a7ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11869)
* 7dea123463f8110e4bff843854c2fc66bc24a7ff Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11888)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20580][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac41760be08390054d51f810056735bb72951d6a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14584:
URL: https://github.com/apache/flink/pull/14584#discussion_r556306735
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobVertex.java
##########
@@ -425,12 +426,12 @@ public void setStrictlyCoLocatedWith(JobVertex strictlyCoLocatedWith) {
"Strict co-location requires that both vertices are in the same slot sharing group.");
}
- CoLocationGroup thisGroup = this.coLocationGroup;
- CoLocationGroup otherGroup = strictlyCoLocatedWith.coLocationGroup;
+ CoLocationGroupImpl thisGroup = this.coLocationGroup;
+ CoLocationGroupImpl otherGroup = strictlyCoLocatedWith.coLocationGroup;
Review comment:
Wouldn't it be cleaner to add the `addVertex()` method to the `CoLocationGroup` interface?
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -1018,10 +1018,10 @@ private void setCoLocation() {
"Cannot use a co-location constraint without a slot sharing group");
}
- Tuple2<SlotSharingGroup, CoLocationGroup> constraint =
+ Tuple2<SlotSharingGroup, CoLocationGroupImpl> constraint =
coLocationGroups.computeIfAbsent(
coLocationGroupKey,
- k -> new Tuple2<>(sharingGroup, new CoLocationGroup()));
+ k -> new Tuple2<>(sharingGroup, new CoLocationGroupImpl()));
Review comment:
Adding the addVertex method to the interface would not require touching this test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20580][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
}, {
"hash" : "bbabee468dc4cea40929884682260ca046e63b48",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855",
"triggerID" : "bbabee468dc4cea40929884682260ca046e63b48",
"triggerType" : "PUSH"
}, {
"hash" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bbabee468dc4cea40929884682260ca046e63b48 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855)
* daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 96bfc4315368e6c105b5a55af9eeff2268990861 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800)
* a7221719360b731dbf1711be4968af87d8f0900b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a7221719360b731dbf1711be4968af87d8f0900b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4393af4fff1792cefbc7d9489e137bd4b0387457 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
}, {
"hash" : "bbabee468dc4cea40929884682260ca046e63b48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855",
"triggerID" : "bbabee468dc4cea40929884682260ca046e63b48",
"triggerType" : "PUSH"
}, {
"hash" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11869",
"triggerID" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"triggerType" : "PUSH"
}, {
"hash" : "7dea123463f8110e4bff843854c2fc66bc24a7ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11888",
"triggerID" : "7dea123463f8110e4bff843854c2fc66bc24a7ff",
"triggerType" : "PUSH"
}, {
"hash" : "51e43557612c34ce0e2803014fa8a00c789ed158",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11905",
"triggerID" : "51e43557612c34ce0e2803014fa8a00c789ed158",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dea123463f8110e4bff843854c2fc66bc24a7ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11888)
* 51e43557612c34ce0e2803014fa8a00c789ed158 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a10a1feecffd930d01e57997abd2db59d4aae762 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796)
* 96bfc4315368e6c105b5a55af9eeff2268990861 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800)
* a7221719360b731dbf1711be4968af87d8f0900b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
}, {
"hash" : "bbabee468dc4cea40929884682260ca046e63b48",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11855",
"triggerID" : "bbabee468dc4cea40929884682260ca046e63b48",
"triggerType" : "PUSH"
}, {
"hash" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11869",
"triggerID" : "daed89fb992f6ea6cc3d6dfb0a1a71dd36d68600",
"triggerType" : "PUSH"
}, {
"hash" : "7dea123463f8110e4bff843854c2fc66bc24a7ff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11888",
"triggerID" : "7dea123463f8110e4bff843854c2fc66bc24a7ff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7dea123463f8110e4bff843854c2fc66bc24a7ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11888)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-759363689
I'll merge the change now! Thanks for working on this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14584: [FLINK-20850][runtime] Removing usage of CoLocationConstraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14584:
URL: https://github.com/apache/flink/pull/14584#issuecomment-756612102
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac41760be08390054d51f810056735bb72951d6a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11787",
"triggerID" : "ac41760be08390054d51f810056735bb72951d6a",
"triggerType" : "PUSH"
}, {
"hash" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11796",
"triggerID" : "a10a1feecffd930d01e57997abd2db59d4aae762",
"triggerType" : "PUSH"
}, {
"hash" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11800",
"triggerID" : "96bfc4315368e6c105b5a55af9eeff2268990861",
"triggerType" : "PUSH"
}, {
"hash" : "a7221719360b731dbf1711be4968af87d8f0900b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11805",
"triggerID" : "a7221719360b731dbf1711be4968af87d8f0900b",
"triggerType" : "PUSH"
}, {
"hash" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823",
"triggerID" : "4393af4fff1792cefbc7d9489e137bd4b0387457",
"triggerType" : "PUSH"
}, {
"hash" : "bbabee468dc4cea40929884682260ca046e63b48",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bbabee468dc4cea40929884682260ca046e63b48",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4393af4fff1792cefbc7d9489e137bd4b0387457 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11823)
* bbabee468dc4cea40929884682260ca046e63b48 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org