[GitHub] [kafka] rajinisivaram commented on a diff in pull request #13081: Re-using callbackHandler for refreshing Kerberos TGT when keytab is not used

[GitBox <gi...@apache.org>]

rajinisivaram commented on code in PR #13081:
URL: https://github.com/apache/kafka/pull/13081#discussion_r1063281046


##########
clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java:
##########
@@ -90,6 +91,7 @@ public void configure(Map<String, ?> configs, String contextName, Configuration
         this.minTimeBeforeRelogin = (Long) configs.get(SaslConfigs.SASL_KERBEROS_MIN_TIME_BEFORE_RELOGIN);
         this.kinitCmd = (String) configs.get(SaslConfigs.SASL_KERBEROS_KINIT_CMD);
         this.serviceName = getServiceName(configs, contextName, configuration);
+        this.callbackHandler = callbackHandler;

Review Comment:
   We could add a protected method `loginCallbackHandler()` to AbstractLogin (similar to `contextName()`) instead of storing it here as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org