You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "jmalkin (via GitHub)" <gi...@apache.org> on 2023/01/21 22:54:52 UTC
[GitHub] [datasketches-cpp] jmalkin opened a new pull request, #334: Build linux arm64/aarch64 wheels
jmalkin opened a new pull request, #334:
URL: https://github.com/apache/datasketches-cpp/pull/334
QEMU seems to be the standard way to build wheels for arm64/aarch64 (same thing) with github actions. Cross compilation doesn't seem to be supported by cibuildwheel currently. The drawback of QEMU is that it's very, very slow.
Also removed a config step by putting the logic into a more appropriate step's env variables.
Tested a reduced set of platforms with a single python version and verified that the .so produced reports back as the right file type. I don't have an AWS instance to test this on, so waiting for the result of testing in #333 . If that works, this should be good to merge (and then maybe back-port into the 4.0.x branch).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] coveralls commented on pull request #334: Build linux arm64/aarch64 wheels
Posted by "coveralls (via GitHub)" <gi...@apache.org>.
coveralls commented on PR #334:
URL: https://github.com/apache/datasketches-cpp/pull/334#issuecomment-1399349488
## Pull Request Test Coverage Report for [Build 3976952721](https://coveralls.io/builds/56165458)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **93.871%**
---
| Totals | [](https://coveralls.io/builds/56165458) |
| :-- | --: |
| Change from base [Build 3914801896](https://coveralls.io/builds/55940795): | 0.0% |
| Covered Lines: | 2328 |
| Relevant Lines: | 2480 |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] will-lauer commented on a diff in pull request #334: Build linux arm64/aarch64 wheels
Posted by "will-lauer (via GitHub)" <gi...@apache.org>.
will-lauer commented on code in PR #334:
URL: https://github.com/apache/datasketches-cpp/pull/334#discussion_r1084123420
##########
.github/workflows/build_wheels.yml:
##########
@@ -3,10 +3,11 @@ name: Build Python Wheels
on:
# allow manual runs
workflow_dispatch:
+
# run when we tag a release
- release:
- types:
- - "created"
+ #release:
+ # types:
+ # - "created"
Review Comment:
Why is this being commented out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin commented on a diff in pull request #334: Build linux arm64/aarch64 wheels
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on code in PR #334:
URL: https://github.com/apache/datasketches-cpp/pull/334#discussion_r1084284711
##########
.github/workflows/build_wheels.yml:
##########
@@ -3,10 +3,11 @@ name: Build Python Wheels
on:
# allow manual runs
workflow_dispatch:
+
# run when we tag a release
- release:
- types:
- - "created"
+ #release:
+ # types:
+ # - "created"
Review Comment:
In practice, we've been including the wheels as part of a release vote. That means they need to be generated prior to creating a release tag, so anything automatically generated here wouldn't be used.
Maybe if someone downloaded the archive to extract the one they need manually as opposed to using pip install? But at that point it seems like they'd just as likely build a wheel locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin merged pull request #334: Build linux arm64/aarch64 wheels
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin merged PR #334:
URL: https://github.com/apache/datasketches-cpp/pull/334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org