You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/29 09:21:49 UTC

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4248: mtd: Add MTDIOC_FIRSTBLOCK for retrieving an MTD partition first block

Ouss4 commented on a change in pull request #4248:
URL: https://github.com/apache/incubator-nuttx/pull/4248#discussion_r678978735



##########
File path: include/nuttx/mtd/mtd.h
##########
@@ -74,6 +74,9 @@
 #define MTDIOC_ERASESTATE _MTDIOC(0x000a) /* IN:  Pointer to uint8_t
                                            * OUT: Byte value that represents the
                                            *      erased state of the MTD cell */
+#define MTDIOC_FIRSTBLOCK _MTDIOC(0x000b) /* IN:  Pointer to off_t

Review comment:
       Does it make sense to have it with `mtd_geometry_s`? Looks a bit out of the scope of what geometry means here. If we added it to mtd_geometry_s, wouldn't be 0 for most cases?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org