You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/08/10 03:08:26 UTC

[GitHub] [kylin] bigxiaochu commented on a change in pull request #1345: KYLIN-4685 return user friendly msg when stackoverflowerror

bigxiaochu commented on a change in pull request #1345:
URL: https://github.com/apache/kylin/pull/1345#discussion_r467670050



##########
File path: query/src/main/java/org/apache/kylin/query/util/QueryUtil.java
##########
@@ -178,6 +178,12 @@ public static String makeErrorMsgUserFriendly(Throwable e) {
                 msg = "NumberFormatException: " + cause.getMessage();
                 break;
             }
+
+            //where in(...) condition has too many elements
+            if (cause.getClass().equals(StackOverflowError.class)) {

Review comment:
       You are right. Modify use message




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org