You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/25 06:02:17 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #28011:
[SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss
parameter
AngersZhuuuu opened a new pull request #28011: [SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss parameter
URL: https://github.com/apache/spark/pull/28011
### What changes were proposed in this pull request?
Fix ExecutorMetricsPoller class comment comment miss parameter
### Why are the changes needed?
Fix comment comment miss parameter
### Does this PR introduce any user-facing change?
NO
### How was this patch tested?
Not need
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #28011:
[SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss
parameter
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on issue #28011: [SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss parameter
URL: https://github.com/apache/spark/pull/28011#issuecomment-603657534
cc @HyukjinKwon
Split to two pr, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28011:
[SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss
parameter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28011: [SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss parameter
URL: https://github.com/apache/spark/pull/28011#issuecomment-603659289
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28011:
[SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss
parameter
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28011: [SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss parameter
URL: https://github.com/apache/spark/pull/28011#issuecomment-603663928
Yes, because it costs Jenkins, review and merge. Also, it's difficult to maintain such PRs e.g., backporting. Let's fix them in batch - it's not worthwhile to make a PR for fixing a couple of typos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28011:
[SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss
parameter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28011: [SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss parameter
URL: https://github.com/apache/spark/pull/28011#issuecomment-603658927
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28011:
[SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss
parameter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28011: [SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss parameter
URL: https://github.com/apache/spark/pull/28011#issuecomment-603658927
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #28011:
[SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss
parameter
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on issue #28011: [SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss parameter
URL: https://github.com/apache/spark/pull/28011#issuecomment-603663192
> No~ @AngersZhuuuu. I meant to make one minor PR to fix many typos instead of making one PR to fix a couple of typos.
emmmm, One pr for more same type typo, not one pr for different typo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28011:
[SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss
parameter
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28011: [SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss parameter
URL: https://github.com/apache/spark/pull/28011
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28011:
[SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss
parameter
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28011: [SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss parameter
URL: https://github.com/apache/spark/pull/28011#issuecomment-603662098
No~ @AngersZhuuuu. I meant to make one minor PR to fix many typos instead of making one PR to fix a couple of typos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28011:
[SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss
parameter
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28011: [SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss parameter
URL: https://github.com/apache/spark/pull/28011#issuecomment-605163480
Like @HyukjinKwon 's advice, we prefer to do this kind of clean up together.
BTW, at that time, this PR will not be a followup of SPARK-26329. It should be an independent documentation fix PR. For now, I close this PR. Please feel free to reuse your code and reopen it when you are ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #28011:
[SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss
parameter
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on issue #28011: [SPARK-26329][CORE][FOLLOWUP] Fix ExecutorMetricsPoller class comment miss parameter
URL: https://github.com/apache/spark/pull/28011#issuecomment-603666860
> Yes, because it costs Jenkins, review and merge. Also, it's difficult to maintain such PRs e.g., backporting. Let's fix them in batch - it's not worthwhile to make a PR for fixing a couple of typos.
ok, I will keep these two pr, and will add more modify to them when I read some code and find such case.
Thanks a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org