You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jason TANG (Jira)" <ji...@apache.org> on 2023/12/26 06:07:00 UTC

[jira] [Commented] (FLINK-33939) Make husky in runtime-web no longer affect git global hooks

    [ https://issues.apache.org/jira/browse/FLINK-33939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800409#comment-17800409 ] 

Jason TANG commented on FLINK-33939:
------------------------------------

Feedback is welcome, I can submit a PR to remove the husky dependency on the front end : )

> Make husky in runtime-web no longer affect git global hooks
> -----------------------------------------------------------
>
>                 Key: FLINK-33939
>                 URL: https://issues.apache.org/jira/browse/FLINK-33939
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Web Frontend
>            Reporter: Jason TANG
>            Priority: Minor
>
> Since runtime-web relies on husky to ensure that front-end code changes are detected before `git commit`, husky modifies the global git hooks (core.hooksPath) so that core.hooksPath won't take effect if it's configured globally, I thought it would be a good idea to make the front-end code detection a optional command execution, which ensures that the globally configured hooks are executed correctly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)