You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/08/06 13:37:59 UTC
Re: Review Request 67844: Bundled libseccomp v2.3.3 into 3rdparty
libraries.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67844/
-----------------------------------------------------------
(Updated Aug. 6, 2018, 1:37 p.m.)
Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
Bugs: MESOS-9032
https://issues.apache.org/jira/browse/MESOS-9032
Repository: mesos
Description
-------
The bundled library is downloaded from the `libseccomp` github page:
https://github.com/seccomp/libseccomp/releases/tag/v2.3.3
This library is bundled for Linux only, because Seccomp is a
Linux-specific feature.
Diffs (updated)
-----
3rdparty/libseccomp-2.3.3.tar.gz PRE-CREATION
Diff: https://reviews.apache.org/r/67844/diff/3/
Changes: https://reviews.apache.org/r/67844/diff/2-3/
Testing
-------
Thanks,
Andrei Budnik
Re: Review Request 67844: Bundled libseccomp v2.3.3 into 3rdparty
libraries.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67844/#review211394
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Aug. 6, 2018, 9:37 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67844/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2018, 9:37 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9032
> https://issues.apache.org/jira/browse/MESOS-9032
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The bundled library is downloaded from the `libseccomp` github page:
> https://github.com/seccomp/libseccomp/releases/tag/v2.3.3
>
> This library is bundled for Linux only, because Seccomp is a
> Linux-specific feature.
>
>
> Diffs
> -----
>
> 3rdparty/libseccomp-2.3.3.tar.gz PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67844/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 67844: Bundled libseccomp v2.3.3 into 3rdparty
libraries.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Dec. 6, 2018, 7:01 p.m., Gilbert Song wrote:
> > Could you post this patch as a github PR? so that I could apply and commit.
https://github.com/apache/mesos/pull/320
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67844/#review211099
-----------------------------------------------------------
On Aug. 6, 2018, 1:37 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67844/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2018, 1:37 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9032
> https://issues.apache.org/jira/browse/MESOS-9032
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The bundled library is downloaded from the `libseccomp` github page:
> https://github.com/seccomp/libseccomp/releases/tag/v2.3.3
>
> This library is bundled for Linux only, because Seccomp is a
> Linux-specific feature.
>
>
> Diffs
> -----
>
> 3rdparty/libseccomp-2.3.3.tar.gz PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67844/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 67844: Bundled libseccomp v2.3.3 into 3rdparty
libraries.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67844/#review211099
-----------------------------------------------------------
Ship it!
Could you post this patch as a github PR? so that I could apply and commit.
- Gilbert Song
On Aug. 6, 2018, 6:37 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67844/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2018, 6:37 a.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
>
>
> Bugs: MESOS-9032
> https://issues.apache.org/jira/browse/MESOS-9032
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The bundled library is downloaded from the `libseccomp` github page:
> https://github.com/seccomp/libseccomp/releases/tag/v2.3.3
>
> This library is bundled for Linux only, because Seccomp is a
> Linux-specific feature.
>
>
> Diffs
> -----
>
> 3rdparty/libseccomp-2.3.3.tar.gz PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/67844/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Budnik
>
>