[GitHub] [skywalking-client-js] kezhenxu94 edited a comment on pull request #45: add `originAllowlist` option

[GitBox <gi...@apache.org>]

kezhenxu94 edited a comment on pull request #45:
URL: https://github.com/apache/skywalking-client-js/pull/45#issuecomment-791886273


   > > There are some suggestions for this. 1. For the SDK name, could you change `originAllowlist ` to `NoTraceOrigins` and update the corresponding logic? 2. It is fine that the type of `originAllowlist` is `(string | RegExp)[]`. 3. the default value of `originAllowlist` is [].
   > 
   > > WDYT? @wu-sheng @kezhenxu94 @tianyk
   > 
   > 
   > 
   > Use blockList if you want. I am +1 to use blocking rather than allowing mechanism. In this case, empty meaning all available makes more sense to me.
   
   Blocking mechanism requires that you must list all uncontrollable domains, some of which may be unknown, allowlist is more preferable in this case since you know which domains you own / control


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org