[jira] [Closed] (MWRAPPER-5) Hardcoded maven-wrapper.jar path

["Robert Scholte (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MWRAPPER-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Scholte closed MWRAPPER-5.
---------------------------------
      Assignee: Robert Scholte
    Resolution: Not A Problem

As describes on https://maven.apache.org/plugins/maven-wrapper-plugin/usage.html there are 3 types of downloads. 
When using {{bin}} it will indeed download the jar. I suggest to pick one of the other types.

> Hardcoded maven-wrapper.jar path
> --------------------------------
>
>                 Key: MWRAPPER-5
>                 URL: https://issues.apache.org/jira/browse/MWRAPPER-5
>             Project: Maven Wrapper
>          Issue Type: Wish
>    Affects Versions: 3.0.1
>         Environment: Linux
>            Reporter: Jorge Solórzano
>            Assignee: Robert Scholte
>            Priority: Normal
>              Labels: features
>
> Not sure how it will work on 3.7.0, but the current Takari maven wrapper has the jar path hardcoded in the script and in the download java class:
> {color:#c586c0}if{color}{color:#d4d4d4} [ -r {color}{color:#ce9178}"{color}{color:#9cdcfe}$BASE_DIR{color}{color:#ce9178}/.mvn/wrapper/maven-wrapper.jar"{color}{color:#d4d4d4} ]; {color}{color:#c586c0}then{color}
> This has the problem in projects that prohibit checking binary data, the strange thing is that when Maven is being downloaded the extracted zip goes to \{user.home}/.m2/wrapper/dists/...
> So what I propose is that the maven-wrapper.jar can also be downloaded in that directory avoiding to download that jar in every project and also be able to change that directory with properties or env variables like how is now possible with MAVEN_USER_HOME=.m2/, this would definitely help with caching in CI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)