You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/09/13 14:33:35 UTC

[GitHub] spark pull request #21048: [SPARK-23966][SS] Refactoring all checkpoint file...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21048#discussion_r217407633
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -930,6 +930,13 @@ object SQLConf {
           .intConf
           .createWithDefault(100)
     
    +  val STREAMING_CHECKPOINT_FILE_MANAGER_CLASS =
    +    buildConf("spark.sql.streaming.checkpointFileManagerClass")
    +      .doc("The class used to write checkpoint files atomically. This class must be a subclass " +
    +        "of the interface CheckpointFileManager.")
    +      .internal()
    +      .stringConf
    --- End diff --
    
    `createOptional`? cc @zsxwing @tdas 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org