You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jagadeesanas2 <gi...@git.apache.org> on 2016/09/10 05:56:33 UTC

[GitHub] spark pull request #15042: [SPARK-17449] [Documentation] [Relation between h...

GitHub user jagadeesanas2 opened a pull request:

    https://github.com/apache/spark/pull/15042

    [SPARK-17449] [Documentation] [Relation between heartbeatInterval and\u2026

    ## What changes were proposed in this pull request?
    
    The relation between spark.network.timeout and spark.executor.heartbeatInterval should be mentioned in the document. 
    
    \u2026 network timeout]

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ibmsoe/spark SPARK-17449

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/15042.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15042
    
----
commit 83031c4d285db633c6468ef8471810765f62c0be
Author: Jagadeesan <as...@us.ibm.com>
Date:   2016-09-10T05:49:41Z

    [SPARK-17449] [Documentation] [Relation between heartbeatInterval and network timeout]

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #15042: [SPARK-17449] [Documentation] [Relation between h...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15042#discussion_r78354202
  
    --- Diff: core/src/main/scala/org/apache/spark/HeartbeatReceiver.scala ---
    @@ -32,6 +32,8 @@ import org.apache.spark.util._
      * A heartbeat from executors to the driver. This is a shared message used by several internal
      * components to convey liveness or execution information for in-progress tasks. It will also
      * expire the hosts that have not heartbeated for more than spark.network.timeout.
    + * spark.executor.heartbeatInterval configuration value is certainly intended to be much
    --- End diff --
    
    OK, the verbatim quote from my email is a little funny with 'certainly', but, not a big deal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15042: [SPARK-17449] [Documentation] [Relation between heartbea...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/15042
  
    I think you can/should add the note to the user-facing configuration doc too. Same note.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15042: [SPARK-17449] [Documentation] [Relation between heartbea...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/15042
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65346/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #15042: [SPARK-17449] [Documentation] [Relation between heartbea...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/15042
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #15042: [SPARK-17449] [Documentation] [Relation between h...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/15042


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org