You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/05/03 08:57:41 UTC

[GitHub] [brooklyn-server] grkvlt commented on a change in pull request #1144: Fixes issue reverting osgi bom files with SNAPSHOT versions

grkvlt commented on a change in pull request #1144:
URL: https://github.com/apache/brooklyn-server/pull/1144#discussion_r624960637



##########
File path: launcher/src/test/java/org/apache/brooklyn/launcher/BrooklynLauncherRebindCatalogOsgiTest.java
##########
@@ -254,8 +254,8 @@ public void testRebindWithSystemBundleInCatalog() throws Exception {
             // Launch brooklyn, where persisted state now includes the initial catalog's bundle
             startT2(newLauncherForTests(initialBomFile.getAbsolutePath()));
             
-            // Should not have replaced the original "system bundle"
-            assertOnlyBundle(reusedFramework, bundleName, pseudoSystemBundle);
+            // FIXME Should we have replaced the original "system bundle" ???
+            assertBundleExists(reusedFramework, bundleName, pseudoSystemBundle);

Review comment:
       reverted test




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org