You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "vineet semwal (JIRA)" <ji...@apache.org> on 2012/05/11 10:14:01 UTC
[jira] [Created] (WICKET-4555) deprecate/remove
pagingnavigator#getpagingnavigation()
vineet semwal created WICKET-4555:
-------------------------------------
Summary: deprecate/remove pagingnavigator#getpagingnavigation()
Key: WICKET-4555
URL: https://issues.apache.org/jira/browse/WICKET-4555
Project: Wicket
Issue Type: Improvement
Affects Versions: 6.0.0-beta1, 1.5.6
Reporter: vineet semwal
pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation field in onbeforerender gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4555) deprecate/remove
pagingnavigator#getpagingnavigation()
Posted by "vineet semwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278699#comment-13278699 ]
vineet semwal commented on WICKET-4555:
---------------------------------------
i have taken a quick look at pagingnavigator and pagingnavigation ,i think it's ok to initialize pagingnavigation in the constructor itself but you will need to test.. it's also quite ok to initialize it in onintialize if you mention in the javadoc of getter that it's populated only after component#onitialize() ...
> deprecate/remove pagingnavigator#getpagingnavigation()
> ------------------------------------------------------
>
> Key: WICKET-4555
> URL: https://issues.apache.org/jira/browse/WICKET-4555
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: vineet semwal
> Labels: pagingnavigator
>
> pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation field in pagingnavigator gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
> thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4555) deprecate/remove
pagingnavigator#getpagingnavigation()
Posted by "vineet semwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
vineet semwal updated WICKET-4555:
----------------------------------
Description:
pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation field in pagingnavigator gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
thanks!
was:
pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation field in onbeforerender gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
thanks!
> deprecate/remove pagingnavigator#getpagingnavigation()
> ------------------------------------------------------
>
> Key: WICKET-4555
> URL: https://issues.apache.org/jira/browse/WICKET-4555
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: vineet semwal
> Labels: pagingnavigator
>
> pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation field in pagingnavigator gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
> thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4555) deprecate/remove
pagingnavigator#getpagingnavigation()
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4555.
-------------------------------------
Resolution: Won't Fix
Moved it to #onInitialize().
I understand that there is still chance to get a 'null' if you use the getter too early but in this case you really need to override #newNavigation(). In all other cases using the getter gives you the flexibility to change its settings.
> deprecate/remove pagingnavigator#getpagingnavigation()
> ------------------------------------------------------
>
> Key: WICKET-4555
> URL: https://issues.apache.org/jira/browse/WICKET-4555
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: vineet semwal
> Labels: pagingnavigator
>
> pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation field in pagingnavigator gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
> thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4555) deprecate/remove
pagingnavigator#getpagingnavigation()
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278656#comment-13278656 ]
Martin Grigorov commented on WICKET-4555:
-----------------------------------------
Let's initialize the pagingNavigator in #onInitialize() instead of the first call of #onBeforeRender().
This way the getter will be still useful in most of the cases.
> deprecate/remove pagingnavigator#getpagingnavigation()
> ------------------------------------------------------
>
> Key: WICKET-4555
> URL: https://issues.apache.org/jira/browse/WICKET-4555
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: vineet semwal
> Labels: pagingnavigator
>
> pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation field in pagingnavigator gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
> thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (WICKET-4555) deprecate/remove
pagingnavigator#getpagingnavigation()
Posted by "vineet semwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278699#comment-13278699 ]
vineet semwal edited comment on WICKET-4555 at 5/18/12 10:18 AM:
-----------------------------------------------------------------
i have taken a quick look at pagingnavigator and pagingnavigation ,i think it's ok to initialize pagingnavigation in the constructor itself but you will need to test.. it's also quite ok to initialize it in onintialize if you mention in the javadoc of getter that it's populated only after pagingnavigator#onitialize() ...
was (Author: vineetsemwal):
i have taken a quick look at pagingnavigator and pagingnavigation ,i think it's ok to initialize pagingnavigation in the constructor itself but you will need to test.. it's also quite ok to initialize it in onintialize if you mention in the javadoc of getter that it's populated only after component#onitialize() ...
> deprecate/remove pagingnavigator#getpagingnavigation()
> ------------------------------------------------------
>
> Key: WICKET-4555
> URL: https://issues.apache.org/jira/browse/WICKET-4555
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: vineet semwal
> Labels: pagingnavigator
>
> pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation field in pagingnavigator gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
> thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4555) deprecate/remove
pagingnavigator#getpagingnavigation()
Posted by "vineet semwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278666#comment-13278666 ]
vineet semwal commented on WICKET-4555:
---------------------------------------
in my opinion it's ok to remove getter but if you want to provide it,i
think it's better to initialize it in getter itself..,
public final PagingNavigation getPagingNavigation()
{
if(pagingNavigation==null){
pagingNavigation=newNavigation("navigation", pageable,
labelProvider);
}
return pagingNavigation;
}
--
thank you,
regards,
Vineet Semwal
> deprecate/remove pagingnavigator#getpagingnavigation()
> ------------------------------------------------------
>
> Key: WICKET-4555
> URL: https://issues.apache.org/jira/browse/WICKET-4555
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: vineet semwal
> Labels: pagingnavigator
>
> pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation field in pagingnavigator gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
> thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4555) deprecate/remove
pagingnavigator#getpagingnavigation()
Posted by "vineet semwal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278674#comment-13278674 ]
vineet semwal commented on WICKET-4555:
---------------------------------------
this way user will always get initialized field..
On Fri, May 18, 2012 at 3:05 PM, vineet semwal
--
thank you,
regards,
Vineet Semwal
> deprecate/remove pagingnavigator#getpagingnavigation()
> ------------------------------------------------------
>
> Key: WICKET-4555
> URL: https://issues.apache.org/jira/browse/WICKET-4555
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: vineet semwal
> Labels: pagingnavigator
>
> pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation field in pagingnavigator gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
> thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4555) deprecate/remove
pagingnavigator#getpagingnavigation()
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278675#comment-13278675 ]
Martin Grigorov commented on WICKET-4555:
-----------------------------------------
For some reason the PagingNavigation is not initialized in the constructor. It seems it needs access to the page/markup/...
By using your approach we may introduce a bug.
> deprecate/remove pagingnavigator#getpagingnavigation()
> ------------------------------------------------------
>
> Key: WICKET-4555
> URL: https://issues.apache.org/jira/browse/WICKET-4555
> Project: Wicket
> Issue Type: Improvement
> Affects Versions: 1.5.6, 6.0.0-beta1
> Reporter: vineet semwal
> Labels: pagingnavigator
>
> pagingnavigator#getpagingnavigation() should be deprecated/removed as pagingnavigation field in pagingnavigator gets populated in onbeforerender and if a user has to use it ,he can only use it in component#onbeforrender ie. after pagingnavigator#onbeforerender and at that time too using it might *not* give desired result . any one who needs to add some configuration can still do in pagingnavigator# newnavigation(*) .
> thanks!
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira