You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "roeap (via GitHub)" <gi...@apache.org> on 2024/12/17 20:31:13 UTC
[PR] chore: more consistently use type conversions [iceberg-rust]
roeap opened a new pull request, #815:
URL: https://github.com/apache/iceberg-rust/pull/815
Hey iceberg-rs!,
looking to start to more actively contribute to the iceberg ecosystem and trying to grock the codebase, I thought maybe some small contributions might be welcome :).
This PR just reduces the surface area for in internal module a little bit, by leveraging partially already defined `TryInto` traits rather then exporting dedicated functions for type conversion.
it is IMO a little bit more idiomatic, buf fully understand if you prefer the current way of doing things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: more consistently use type conversions [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #815:
URL: https://github.com/apache/iceberg-rust/pull/815#issuecomment-2550171155
Hi, thank you @roeap for working on this. It's intentional that we provide a clear API for the conversion. This ensures an easy-to-find and discoverable API for users. In the near future, we might introduce `SchemeConverter` to allow users to configure the conversion. Therefore, there are no plans to change it to `TryFrom`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: more consistently use type conversions [iceberg-rust]
Posted by "roeap (via GitHub)" <gi...@apache.org>.
roeap closed pull request #815: chore: more consistently use type conversions
URL: https://github.com/apache/iceberg-rust/pull/815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: more consistently use type conversions [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on PR #815:
URL: https://github.com/apache/iceberg-rust/pull/815#issuecomment-2550191862
Thanks @roeap for contributing! About this pr, I agree with @Xuanwo that explicit function call makes code easier to read, and there is no strong motivation to change it to `TryFrom`. But I agree that maybe we could provide a `TryFrom` implementation so that external users could choose it freely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] chore: more consistently use type conversions [iceberg-rust]
Posted by "roeap (via GitHub)" <gi...@apache.org>.
roeap commented on PR #815:
URL: https://github.com/apache/iceberg-rust/pull/815#issuecomment-2550581317
@Xuanwo @liurenjie1024 - understood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org