[jira] [Commented] (FLINK-6571) InfiniteSource in SourceStreamOperatorTest should deal with InterruptedExceptions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348512#comment-16348512 ] 

ASF GitHub Bot commented on FLINK-6571:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5394
  
    It may not be a problem in this test, but I wanted to raise that this pattern is a bit dangerous.
    If the thread ever gets interrupted while 'running' is still true, this goes into a hot loop constantly throwing exceptions: Every time it falls through the loop and attempts to sleep again, it will immediately throw an Interrupted Exception.


> InfiniteSource in SourceStreamOperatorTest should deal with InterruptedExceptions
> ---------------------------------------------------------------------------------
>
>                 Key: FLINK-6571
>                 URL: https://issues.apache.org/jira/browse/FLINK-6571
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.3.0, 1.4.0, 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Minor
>              Labels: test-stability
>             Fix For: 1.5.0
>
>
> So this is a new one: i got a failing test ({{testNoMaxWatermarkOnAsyncStop}}) due to an uncatched InterruptedException.
> {code}
> [00:28:15] Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.828 sec <<< FAILURE! - in org.apache.flink.streaming.runtime.operators.StreamSourceOperatorTest
> [00:28:15] testNoMaxWatermarkOnAsyncStop(org.apache.flink.streaming.runtime.operators.StreamSourceOperatorTest)  Time elapsed: 0 sec  <<< ERROR!
> [00:28:15] java.lang.InterruptedException: sleep interrupted
> [00:28:15] 	at java.lang.Thread.sleep(Native Method)
> [00:28:15] 	at org.apache.flink.streaming.runtime.operators.StreamSourceOperatorTest$InfiniteSource.run(StreamSourceOperatorTest.java:343)
> [00:28:15] 	at org.apache.flink.streaming.api.operators.StreamSource.run(StreamSource.java:87)
> [00:28:15] 	at org.apache.flink.streaming.runtime.operators.StreamSourceOperatorTest.testNoMaxWatermarkOnAsyncStop(StreamSourceOperatorTest.java:176)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)