[jira] [Commented] (WHIMSY-137) roster/main.rb: strange header values for committer/index.json

["Sam Ruby (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WHIMSY-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159960#comment-16159960 ] 

Sam Ruby commented on WHIMSY-137:
---------------------------------

https://github.com/apache/whimsy/commit/e29a1318523fe1ede033bc84e5421b4466053044 fixes the content type issue (thanks!)

I'm not seeing ancient expires values (not that I doubt that you have).  The code had an unrelated problem that I have now fixed, but in any case before and after this change it should generate a result that is guaranteed to be a minimum of 60 seconds in the future:

  expires [300 - (Time.now-index_time), 60].max

> roster/main.rb: strange header values for committer/index.json
> --------------------------------------------------------------
>
>                 Key: WHIMSY-137
>                 URL: https://issues.apache.org/jira/browse/WHIMSY-137
>             Project: Whimsy
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>
> roster/main.rb generates some strange header values for roster/committer/index.json:
> charset: UTF-8
> type: application/json
> Expires: Thu, 01 Jan 1970 00:01:27 GMT
> Content-Type: text/html;charset=utf-8
> Is the content-type really supposed to be text/html?
> Also the Expires field can sometimes be ancient.
> Looks like the calculation goes wrong sometimes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)