You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/09 13:17:25 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request #31537: [SPARK-34408][PYTHON] Refactor spark.udf.register to share the same path to generate UDF instance

HyukjinKwon opened a new pull request #31537:
URL: https://github.com/apache/spark/pull/31537


   ### What changes were proposed in this pull request?
   
   This PR proposes to use `_create_udf` where we need to create `UserDefinedFunction` to maintain codes easier.
   
   ### Why are the changes needed?
   
   For the better readability of codes and maintenance. 
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, refactoring.
   
   ### How was this patch tested?
   
   Ran the existing unittests. CI in this PR should test it out too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31537: [SPARK-34408][PYTHON] Refactor spark.udf.register to share the same path to generate UDF instance

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31537:
URL: https://github.com/apache/spark/pull/31537#issuecomment-775947327


   **[Test build #135072 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135072/testReport)** for PR 31537 at commit [`9ea7ebe`](https://github.com/apache/spark/commit/9ea7ebeeb7c678d9aa02cf1bc11c25937e8619ab).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31537: [SPARK-34408][PYTHON] Refactor spark.udf.register to share the same path to generate UDF instance

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31537:
URL: https://github.com/apache/spark/pull/31537#issuecomment-775932102


   **[Test build #135072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135072/testReport)** for PR 31537 at commit [`9ea7ebe`](https://github.com/apache/spark/commit/9ea7ebeeb7c678d9aa02cf1bc11c25937e8619ab).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31537: [SPARK-34408][PYTHON] Refactor spark.udf.register to share the same path to generate UDF instance

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31537:
URL: https://github.com/apache/spark/pull/31537#issuecomment-776018580


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39654/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31537: [SPARK-34408][PYTHON] Refactor spark.udf.register to share the same path to generate UDF instance

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31537:
URL: https://github.com/apache/spark/pull/31537#issuecomment-775975087


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135072/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31537: [SPARK-34408][PYTHON] Refactor spark.udf.register to share the same path to generate UDF instance

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31537:
URL: https://github.com/apache/spark/pull/31537#issuecomment-775932102


   **[Test build #135072 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135072/testReport)** for PR 31537 at commit [`9ea7ebe`](https://github.com/apache/spark/commit/9ea7ebeeb7c678d9aa02cf1bc11c25937e8619ab).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31537: [SPARK-34408][PYTHON] Refactor spark.udf.register to share the same path to generate UDF instance

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31537:
URL: https://github.com/apache/spark/pull/31537#issuecomment-777159268


   Thanks @ueshin. Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31537: [SPARK-34408][PYTHON] Refactor spark.udf.register to share the same path to generate UDF instance

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31537:
URL: https://github.com/apache/spark/pull/31537#issuecomment-776018580


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39654/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31537: [SPARK-34408][PYTHON] Refactor spark.udf.register to share the same path to generate UDF instance

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31537:
URL: https://github.com/apache/spark/pull/31537#issuecomment-775928142


   cc @ueshin @viirya can you take a quick look please?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31537: [SPARK-34408][PYTHON] Refactor spark.udf.register to share the same path to generate UDF instance

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31537:
URL: https://github.com/apache/spark/pull/31537#issuecomment-775975087


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135072/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #31537: [SPARK-34408][PYTHON] Refactor spark.udf.register to share the same path to generate UDF instance

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31537:
URL: https://github.com/apache/spark/pull/31537


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org