You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@brooklyn.apache.org by sv...@apache.org on 2016/10/21 09:09:57 UTC

[1/4] brooklyn-library git commit: BindDnsServerImpl checks that ADDRESS_SENSOR was set.

Repository: brooklyn-library
Updated Branches:
  refs/heads/master 96a0445a7 -> 1db9b4f7b


BindDnsServerImpl checks that ADDRESS_SENSOR was set.


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-library/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-library/commit/f0828cde
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-library/tree/f0828cde
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-library/diff/f0828cde

Branch: refs/heads/master
Commit: f0828cdedde517533acf3784feb740308629fea7
Parents: 96a0445
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Authored: Thu Oct 20 13:40:14 2016 +0100
Committer: Sam Corbett <sa...@cloudsoftcorp.com>
Committed: Thu Oct 20 13:40:14 2016 +0100

----------------------------------------------------------------------
 .../org/apache/brooklyn/entity/network/bind/BindDnsServerImpl.java  | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/brooklyn-library/blob/f0828cde/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindDnsServerImpl.java
----------------------------------------------------------------------
diff --git a/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindDnsServerImpl.java b/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindDnsServerImpl.java
index ef53bc4..a210e55 100644
--- a/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindDnsServerImpl.java
+++ b/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindDnsServerImpl.java
@@ -105,6 +105,7 @@ public class BindDnsServerImpl extends SoftwareProcessImpl implements BindDnsSer
     public void init() {
         super.init();
         checkNotNull(getConfig(HOSTNAME_SENSOR), "%s requires value for %s", getClass().getName(), HOSTNAME_SENSOR);
+        checkNotNull(getConfig(ADDRESS_SENSOR), "%s requires value for %s", getClass().getName(), ADDRESS_SENSOR);
         DynamicGroup entities = addChild(EntitySpec.create(DynamicGroup.class)
                 .displayName("BIND-managed entities")
                 .configure(DynamicGroup.ENTITY_FILTER, getEntityFilter()));


[2/4] brooklyn-library git commit: Correct working directory on RHEL

Posted by sv...@apache.org.
Correct working directory on RHEL

Previously it would use .../data/data


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-library/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-library/commit/fe1de31e
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-library/tree/fe1de31e
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-library/diff/fe1de31e

Branch: refs/heads/master
Commit: fe1de31edf537d14d42e1a80bb28967d4212977c
Parents: f0828cd
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Authored: Thu Oct 20 14:24:36 2016 +0100
Committer: Sam Corbett <sa...@cloudsoftcorp.com>
Committed: Thu Oct 20 14:24:36 2016 +0100

----------------------------------------------------------------------
 .../org/apache/brooklyn/entity/network/bind/BindOsSupport.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/brooklyn-library/blob/fe1de31e/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindOsSupport.java
----------------------------------------------------------------------
diff --git a/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindOsSupport.java b/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindOsSupport.java
index c48f8a3..18ecf51 100644
--- a/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindOsSupport.java
+++ b/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindOsSupport.java
@@ -62,7 +62,7 @@ public class BindOsSupport {
                 "named",
                 "/etc/named.conf",
                 "/var/named",
-                "/var/named/data",
+                "/var/named",
                 "/var/named/named.ca",
                 "/etc/named.iscdlv.key");
     }


[3/4] brooklyn-library git commit: BindDns entity sets user running service per operating system

Posted by sv...@apache.org.
BindDns entity sets user running service per operating system

Use "named" on RHEL and "bind" on Ubuntu


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-library/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-library/commit/24cb3810
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-library/tree/24cb3810
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-library/diff/24cb3810

Branch: refs/heads/master
Commit: 24cb3810a86f9c872042827f340ca1e02f72d29c
Parents: fe1de31
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Authored: Thu Oct 20 14:25:17 2016 +0100
Committer: Sam Corbett <sa...@cloudsoftcorp.com>
Committed: Thu Oct 20 14:25:17 2016 +0100

----------------------------------------------------------------------
 .../brooklyn/entity/network/bind/BindDnsServerSshDriver.java | 2 +-
 .../apache/brooklyn/entity/network/bind/BindOsSupport.java   | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/brooklyn-library/blob/24cb3810/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindDnsServerSshDriver.java
----------------------------------------------------------------------
diff --git a/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindDnsServerSshDriver.java b/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindDnsServerSshDriver.java
index ad0aaff..150cfb9 100644
--- a/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindDnsServerSshDriver.java
+++ b/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindDnsServerSshDriver.java
@@ -76,7 +76,7 @@ public class BindDnsServerSshDriver extends AbstractSoftwareProcessSshDriver imp
 
         List<String> commands = Lists.newArrayList(
                 BashCommands.sudo("mkdir -p " + getDataDirectory() + " " + getDynamicDirectory() + " " + getOsSupport().getConfigDirectory()),
-                BashCommands.sudo("chown -R bind:bind " + getDataDirectory() + " " + getDynamicDirectory()),
+                BashCommands.sudo("chown -R " + getOsSupport().getUser() + ":" + getOsSupport().getUser() + " " + getDataDirectory() + " " + getDynamicDirectory()),
                 // TODO determine name of ethernet interface if not eth0?
                 IptablesCommands.insertIptablesRule(Chain.INPUT, "eth0", Protocol.UDP, dnsPort, Policy.ACCEPT),
                 IptablesCommands.insertIptablesRule(Chain.INPUT, "eth0", Protocol.TCP, dnsPort, Policy.ACCEPT),

http://git-wip-us.apache.org/repos/asf/brooklyn-library/blob/24cb3810/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindOsSupport.java
----------------------------------------------------------------------
diff --git a/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindOsSupport.java b/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindOsSupport.java
index 18ecf51..ad681c7 100644
--- a/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindOsSupport.java
+++ b/software/network/src/main/java/org/apache/brooklyn/entity/network/bind/BindOsSupport.java
@@ -30,6 +30,7 @@ public class BindOsSupport {
     // Likewise would make these package-private and have no getters if Freemarker was ok with it.
     private final String packageName;
     private final String serviceName;
+    private final String user;
     private final String rootConfigFile;
     private final String configDirectory;
     private final String workingDirectory;
@@ -39,6 +40,7 @@ public class BindOsSupport {
     private BindOsSupport(
             String packageName,
             String serviceName,
+            String user,
             String rootConfigFile,
             String configDirectory,
             String workingDirectory,
@@ -46,6 +48,7 @@ public class BindOsSupport {
             String keysFile) {
         this.packageName = packageName;
         this.serviceName = serviceName;
+        this.user = user;
         this.rootConfigFile = rootConfigFile;
         this.configDirectory = configDirectory;
         this.workingDirectory = workingDirectory;
@@ -60,6 +63,7 @@ public class BindOsSupport {
         return new BindOsSupport(
                 "bind",
                 "named",
+                "named",
                 "/etc/named.conf",
                 "/var/named",
                 "/var/named",
@@ -74,6 +78,7 @@ public class BindOsSupport {
         return new BindOsSupport(
                 "bind9",
                 "bind9",
+                "bind",
                 "/etc/bind/named.conf",
                 "/etc/bind",
                 "/var/cache/bind",
@@ -110,4 +115,7 @@ public class BindOsSupport {
         return keysFile;
     }
 
+    public String getUser() {
+        return user;
+    }
 }


[4/4] brooklyn-library git commit: Closes #68

Posted by sv...@apache.org.
Closes #68

BindDns improvements for CentOS

On CentOS bind is run by `named`, on Debian it is `bind`. Previously we used the latter in both cases.


Project: http://git-wip-us.apache.org/repos/asf/brooklyn-library/repo
Commit: http://git-wip-us.apache.org/repos/asf/brooklyn-library/commit/1db9b4f7
Tree: http://git-wip-us.apache.org/repos/asf/brooklyn-library/tree/1db9b4f7
Diff: http://git-wip-us.apache.org/repos/asf/brooklyn-library/diff/1db9b4f7

Branch: refs/heads/master
Commit: 1db9b4f7bf8a8aaf4339ac497c7e9e0039d4ac4d
Parents: 96a0445 24cb381
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Authored: Fri Oct 21 10:09:42 2016 +0100
Committer: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Committed: Fri Oct 21 10:09:42 2016 +0100

----------------------------------------------------------------------
 .../brooklyn/entity/network/bind/BindDnsServerImpl.java   |  1 +
 .../entity/network/bind/BindDnsServerSshDriver.java       |  2 +-
 .../brooklyn/entity/network/bind/BindOsSupport.java       | 10 +++++++++-
 3 files changed, 11 insertions(+), 2 deletions(-)
----------------------------------------------------------------------