You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/08/15 17:11:13 UTC
impala git commit: Download gdb from the toolchain and add it to the
path
Repository: impala
Updated Branches:
refs/heads/master cddb35be9 -> 1455548c8
Download gdb from the toolchain and add it to the path
This patch extends the toolchain bootstrap code with the toolchain
version of GDB (v7.9.1, built in the toolchain since its inception),
and adds it to the path. The goal is to provide a stable gdb version
for core dump analysis.
Change-Id: If4e094db93da4f5dab1e1b2da7f88a1dd06bc9e6
Reviewed-on: http://gerrit.cloudera.org:8080/11215
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/1455548c
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/1455548c
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/1455548c
Branch: refs/heads/master
Commit: 1455548c8cd09381fcb74daade870c2e1a5c310a
Parents: cddb35b
Author: Laszlo Gaal <la...@cloudera.com>
Authored: Tue Aug 14 16:16:45 2018 +0200
Committer: Tim Armstrong <ta...@cloudera.com>
Committed: Wed Aug 15 17:10:48 2018 +0000
----------------------------------------------------------------------
bin/bootstrap_toolchain.py | 4 ++--
bin/impala-config.sh | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/1455548c/bin/bootstrap_toolchain.py
----------------------------------------------------------------------
diff --git a/bin/bootstrap_toolchain.py b/bin/bootstrap_toolchain.py
index cbddfbb..2d036f2 100755
--- a/bin/bootstrap_toolchain.py
+++ b/bin/bootstrap_toolchain.py
@@ -426,8 +426,8 @@ if __name__ == "__main__":
# their download starts as soon as possible.
packages = map(Package, ["llvm", "kudu",
"avro", "binutils", "boost", "breakpad", "bzip2", "cctz", "cmake", "crcutil",
- "flatbuffers", "gcc", "gflags", "glog", "gperftools", "gtest", "libev", "libunwind",
- "lz4", "openldap", "openssl", "orc", "protobuf",
+ "flatbuffers", "gcc", "gdb", "gflags", "glog", "gperftools", "gtest", "libev",
+ "libunwind", "lz4", "openldap", "openssl", "orc", "protobuf",
"rapidjson", "re2", "snappy", "thrift", "tpc-h", "tpc-ds", "zlib"])
packages.insert(0, Package("llvm", "5.0.1-asserts-p1"))
bootstrap(toolchain_root, packages)
http://git-wip-us.apache.org/repos/asf/impala/blob/1455548c/bin/impala-config.sh
----------------------------------------------------------------------
diff --git a/bin/impala-config.sh b/bin/impala-config.sh
index 0fc3516..2c1530f 100755
--- a/bin/impala-config.sh
+++ b/bin/impala-config.sh
@@ -93,6 +93,8 @@ export IMPALA_FLATBUFFERS_VERSION=1.6.0
unset IMPALA_FLATBUFFERS_URL
export IMPALA_GCC_VERSION=4.9.2
unset IMPALA_GCC_URL
+export IMPALA_GDB_VERSION=7.9.1
+unset IMPALA_GDB_URL
export IMPALA_GFLAGS_VERSION=2.2.0-p1
unset IMPALA_GFLAGS_URL
export IMPALA_GLOG_VERSION=0.3.4-p3
@@ -473,6 +475,7 @@ export IMPALA_AUX_WORKLOAD_DIR="$IMPALA_AUX_TEST_HOME/testdata/workloads"
export IMPALA_DATASET_DIR="$IMPALA_HOME/testdata/datasets"
export IMPALA_AUX_DATASET_DIR="$IMPALA_AUX_TEST_HOME/testdata/datasets"
export IMPALA_COMMON_DIR="$IMPALA_HOME/common"
+export PATH="$IMPALA_TOOLCHAIN/gdb-$IMPALA_GDB_VERSION/bin:$PATH"
export PATH="$IMPALA_HOME/bin:$IMPALA_TOOLCHAIN/cmake-$IMPALA_CMAKE_VERSION/bin/:$PATH"
# The directory in which all the thirdparty CDH components live.