You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2021/08/19 21:21:20 UTC

[GitHub] [samza] dxichen opened a new pull request #1521: SAMZA-2674: Remove unnecessary init call

dxichen opened a new pull request #1521:
URL: https://github.com/apache/samza/pull/1521


   Remove unused init calls in storage engine and key value store
   
   @Sanil15 @prateekm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [samza] dxichen commented on pull request #1521: SAMZA-2674: Change StorageEngine and KeyValueStore init call parameters

Posted by GitBox <gi...@apache.org>.
dxichen commented on pull request #1521:
URL: https://github.com/apache/samza/pull/1521#issuecomment-902325210


   The build failure seems to be caused by a library being deprecated, updated it here: https://github.com/apache/samza/pull/1522


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [samza] Sanil15 commented on pull request #1521: SAMZA-2674: Change StorageEngine and KeyValueStore init call parameters

Posted by GitBox <gi...@apache.org>.
Sanil15 commented on pull request #1521:
URL: https://github.com/apache/samza/pull/1521#issuecomment-902846474


   > Update the StorageEngine and KeyValueStore apis to only use Context parameter for custom store types
   
   @dxichen please ensure wrapped store init is invoked and not raw store, else LGTM
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [samza] dxichen commented on pull request #1521: SAMZA-2674: Change StorageEngine and KeyValueStore init call parameters

Posted by GitBox <gi...@apache.org>.
dxichen commented on pull request #1521:
URL: https://github.com/apache/samza/pull/1521#issuecomment-932487215


   
   > @dxichen please ensure wrapped store init is invoked and not raw store in the new lifecycle, else LGTM
   
   @Sanil15 yep, it is evoking wrapped store and not raw store directly
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [samza] Sanil15 edited a comment on pull request #1521: SAMZA-2674: Change StorageEngine and KeyValueStore init call parameters

Posted by GitBox <gi...@apache.org>.
Sanil15 edited a comment on pull request #1521:
URL: https://github.com/apache/samza/pull/1521#issuecomment-902846474


   > Update the StorageEngine and KeyValueStore apis to only use Context parameter for custom store types
   
   @dxichen please ensure wrapped store init is invoked and not raw store in the new lifecycle, else LGTM
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [samza] dxichen merged pull request #1521: SAMZA-2674: Change StorageEngine and KeyValueStore init call parameters

Posted by GitBox <gi...@apache.org>.
dxichen merged pull request #1521:
URL: https://github.com/apache/samza/pull/1521


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org